Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Resource Configuration in yorkie-mongodb Helm chart #872

Merged
merged 2 commits into from
May 24, 2024
Merged

Add Resource Configuration in yorkie-mongodb Helm chart #872

merged 2 commits into from
May 24, 2024

Conversation

krapie
Copy link
Member

@krapie krapie commented May 23, 2024 •
edited by coderabbitai bot
Loading

What this PR does / why we need it:

Add resource configuration in yorkie-mongodb Helm chart which is essential for production workloads.

Especially, this is to prevent shard data node's WiredTiger cache to over-consume host's memory.

Which issue(s) this PR fixes:

Fixes https://github.com/yorkie-team/devops/issues/94

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Additional documentation:

Checklist:

  • Added relevant tests or not required
  • Didn't break anything

Summary by CodeRabbit

  • New Features

    • Improved resource management for mongodb-sharded components, including shardsvr, configsvr, and mongos.

  • Enhancements

    • Set memory limits to 2Gi and memory requests to 1Gi for the shardsvr component to ensure better performance and stability.

@krapie krapie added the enhancement 🌟 New feature or request label May 23, 2024
@krapie krapie requested review from hackerwins and sejongk May 23, 2024 14:23
@krapie krapie self-assigned this May 23, 2024
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented May 23, 2024 •
edited
Loading

Walkthrough

The recent changes involve enhancing resource specifications for the shardsvr component in build/charts/yorkie-mongodb/values.yaml, setting memory limits and requests. Empty resources blocks are also added to configsvr and mongos components for future adjustments.

Changes

Files/Paths Change Summary
build/charts/yorkie-mongodb/values.yaml Added memory resource limits and requests to shardsvr; added empty resources blocks to configsvr and mongos.

🐰
In the land of code, where data flows,
Resources now, in YAML rows.
Memory set, for shardsvr to run,
Limits and requests, the job well done.
Configsvr and mongos await their turn,
For future tweaks, as we discern.
🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed May 23, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 28cbd37 and 56e57aa.
Files selected for processing (1)
  • build/charts/yorkie-mongodb/values.yaml (3 hunks)
Additional comments not posted (1)
build/charts/yorkie-mongodb/values.yaml (1)

158-162: Resource configuration for shardsvr looks appropriate for managing memory consumption.

build/charts/yorkie-mongodb/values.yaml Show resolved Hide resolved
build/charts/yorkie-mongodb/values.yaml Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented May 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.59%. Comparing base (28cbd37) to head (234c243).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #872   +/-   ##
=======================================
  Coverage   50.59%   50.59%           
=======================================
  Files          70       70           
  Lines       10389    10389           
=======================================
  Hits         5256     5256           
  Misses       4602     4602           
  Partials      531      531

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

coderabbitai[bot]
coderabbitai bot reviewed May 23, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 56e57aa and 234c243.
Files selected for processing (1)
  • build/charts/yorkie-mongodb/values.yaml (3 hunks)
Files skipped from review as they are similar to previous changes (1)
  • build/charts/yorkie-mongodb/values.yaml

github-actions[bot]
github-actions bot reviewed May 23, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go Benchmark

Benchmark suite Current: 234c243 Previous: 56e57aa Ratio
BenchmarkDocument/constructor_test 1511 ns/op 1224 B/op 21 allocs/op 1414 ns/op 1224 B/op 21 allocs/op 1.07
BenchmarkDocument/constructor_test - ns/op 1511 ns/op 1414 ns/op 1.07
BenchmarkDocument/constructor_test - B/op 1224 B/op 1224 B/op 1
BenchmarkDocument/constructor_test - allocs/op 21 allocs/op 21 allocs/op 1
BenchmarkDocument/status_test 939.5 ns/op 1192 B/op 19 allocs/op 859.3 ns/op 1192 B/op 19 allocs/op 1.09
BenchmarkDocument/status_test - ns/op 939.5 ns/op 859.3 ns/op 1.09
BenchmarkDocument/status_test - B/op 1192 B/op 1192 B/op 1
BenchmarkDocument/status_test - allocs/op 19 allocs/op 19 allocs/op 1
BenchmarkDocument/equals_test 8065 ns/op 6977 B/op 124 allocs/op 7455 ns/op 6977 B/op 124 allocs/op 1.08
BenchmarkDocument/equals_test - ns/op 8065 ns/op 7455 ns/op 1.08
BenchmarkDocument/equals_test - B/op 6977 B/op 6977 B/op 1
BenchmarkDocument/equals_test - allocs/op 124 allocs/op 124 allocs/op 1
BenchmarkDocument/nested_update_test 17779 ns/op 12059 B/op 260 allocs/op 16759 ns/op 12059 B/op 260 allocs/op 1.06
BenchmarkDocument/nested_update_test - ns/op 17779 ns/op 16759 ns/op 1.06
BenchmarkDocument/nested_update_test - B/op 12059 B/op 12059 B/op 1
BenchmarkDocument/nested_update_test - allocs/op 260 allocs/op 260 allocs/op 1
BenchmarkDocument/delete_test 24450 ns/op 15283 B/op 339 allocs/op 22651 ns/op 15283 B/op 339 allocs/op 1.08
BenchmarkDocument/delete_test - ns/op 24450 ns/op 22651 ns/op 1.08
BenchmarkDocument/delete_test - B/op 15283 B/op 15283 B/op 1
BenchmarkDocument/delete_test - allocs/op 339 allocs/op 339 allocs/op 1
BenchmarkDocument/object_test 10817 ns/op 6753 B/op 118 allocs/op 8600 ns/op 6753 B/op 118 allocs/op 1.26
BenchmarkDocument/object_test - ns/op 10817 ns/op 8600 ns/op 1.26
BenchmarkDocument/object_test - B/op 6753 B/op 6753 B/op 1
BenchmarkDocument/object_test - allocs/op 118 allocs/op 118 allocs/op 1
BenchmarkDocument/array_test 31380 ns/op 11883 B/op 274 allocs/op 32478 ns/op 11883 B/op 274 allocs/op 0.97
BenchmarkDocument/array_test - ns/op 31380 ns/op 32478 ns/op 0.97
BenchmarkDocument/array_test - B/op 11883 B/op 11883 B/op 1
BenchmarkDocument/array_test - allocs/op 274 allocs/op 274 allocs/op 1
BenchmarkDocument/text_test 32763 ns/op 14652 B/op 467 allocs/op 30713 ns/op 14651 B/op 467 allocs/op 1.07
BenchmarkDocument/text_test - ns/op 32763 ns/op 30713 ns/op 1.07
BenchmarkDocument/text_test - B/op 14652 B/op 14651 B/op 1.00
BenchmarkDocument/text_test - allocs/op 467 allocs/op 467 allocs/op 1
BenchmarkDocument/text_composition_test 31125 ns/op 18359 B/op 482 allocs/op 29317 ns/op 18358 B/op 482 allocs/op 1.06
BenchmarkDocument/text_composition_test - ns/op 31125 ns/op 29317 ns/op 1.06
BenchmarkDocument/text_composition_test - B/op 18359 B/op 18358 B/op 1.00
BenchmarkDocument/text_composition_test - allocs/op 482 allocs/op 482 allocs/op 1
BenchmarkDocument/rich_text_test 86306 ns/op 38413 B/op 1146 allocs/op 80611 ns/op 38413 B/op 1146 allocs/op 1.07
BenchmarkDocument/rich_text_test - ns/op 86306 ns/op 80611 ns/op 1.07
BenchmarkDocument/rich_text_test - B/op 38413 B/op 38413 B/op 1
BenchmarkDocument/rich_text_test - allocs/op 1146 allocs/op 1146 allocs/op 1
BenchmarkDocument/counter_test 18637 ns/op 10658 B/op 242 allocs/op 17289 ns/op 10658 B/op 242 allocs/op 1.08
BenchmarkDocument/counter_test - ns/op 18637 ns/op 17289 ns/op 1.08
BenchmarkDocument/counter_test - B/op 10658 B/op 10658 B/op 1
BenchmarkDocument/counter_test - allocs/op 242 allocs/op 242 allocs/op 1
BenchmarkDocument/text_edit_gc_100 1295180 ns/op 870752 B/op 16687 allocs/op 1190373 ns/op 870719 B/op 16687 allocs/op 1.09
BenchmarkDocument/text_edit_gc_100 - ns/op 1295180 ns/op 1190373 ns/op 1.09
BenchmarkDocument/text_edit_gc_100 - B/op 870752 B/op 870719 B/op 1.00
BenchmarkDocument/text_edit_gc_100 - allocs/op 16687 allocs/op 16687 allocs/op 1
BenchmarkDocument/text_edit_gc_1000 54960352 ns/op 50536648 B/op 181604 allocs/op 49979571 ns/op 50536256 B/op 181604 allocs/op 1.10
BenchmarkDocument/text_edit_gc_1000 - ns/op 54960352 ns/op 49979571 ns/op 1.10
BenchmarkDocument/text_edit_gc_1000 - B/op 50536648 B/op 50536256 B/op 1.00
BenchmarkDocument/text_edit_gc_1000 - allocs/op 181604 allocs/op 181604 allocs/op 1
BenchmarkDocument/text_split_gc_100 1961819 ns/op 1528627 B/op 15539 allocs/op 1808554 ns/op 1528712 B/op 15539 allocs/op 1.08
BenchmarkDocument/text_split_gc_100 - ns/op 1961819 ns/op 1808554 ns/op 1.08
BenchmarkDocument/text_split_gc_100 - B/op 1528627 B/op 1528712 B/op 1.00
BenchmarkDocument/text_split_gc_100 - allocs/op 15539 allocs/op 15539 allocs/op 1
BenchmarkDocument/text_split_gc_1000 125305074 ns/op 135076208 B/op 182085 allocs/op 114610277 ns/op 135077583 B/op 182090 allocs/op 1.09
BenchmarkDocument/text_split_gc_1000 - ns/op 125305074 ns/op 114610277 ns/op 1.09
BenchmarkDocument/text_split_gc_1000 - B/op 135076208 B/op 135077583 B/op 1.00
BenchmarkDocument/text_split_gc_1000 - allocs/op 182085 allocs/op 182090 allocs/op 1.00
BenchmarkDocument/text_delete_all_10000 19337518 ns/op 10183808 B/op 40678 allocs/op 18153452 ns/op 10183242 B/op 40675 allocs/op 1.07
BenchmarkDocument/text_delete_all_10000 - ns/op 19337518 ns/op 18153452 ns/op 1.07
BenchmarkDocument/text_delete_all_10000 - B/op 10183808 B/op 10183242 B/op 1.00
BenchmarkDocument/text_delete_all_10000 - allocs/op 40678 allocs/op 40675 allocs/op 1.00
BenchmarkDocument/text_delete_all_100000 373112512 ns/op 142691109 B/op 411719 allocs/op 344023684 ns/op 142668388 B/op 411680 allocs/op 1.08
BenchmarkDocument/text_delete_all_100000 - ns/op 373112512 ns/op 344023684 ns/op 1.08
BenchmarkDocument/text_delete_all_100000 - B/op 142691109 B/op 142668388 B/op 1.00
BenchmarkDocument/text_delete_all_100000 - allocs/op 411719 allocs/op 411680 allocs/op 1.00
BenchmarkDocument/text_100 236335 ns/op 119971 B/op 5079 allocs/op 224200 ns/op 119971 B/op 5079 allocs/op 1.05
BenchmarkDocument/text_100 - ns/op 236335 ns/op 224200 ns/op 1.05
BenchmarkDocument/text_100 - B/op 119971 B/op 119971 B/op 1
BenchmarkDocument/text_100 - allocs/op 5079 allocs/op 5079 allocs/op 1
BenchmarkDocument/text_1000 2576897 ns/op 1168961 B/op 50083 allocs/op 2389435 ns/op 1168957 B/op 50083 allocs/op 1.08
BenchmarkDocument/text_1000 - ns/op 2576897 ns/op 2389435 ns/op 1.08
BenchmarkDocument/text_1000 - B/op 1168961 B/op 1168957 B/op 1.00
BenchmarkDocument/text_1000 - allocs/op 50083 allocs/op 50083 allocs/op 1
BenchmarkDocument/array_1000 1300606 ns/op 1091330 B/op 11829 allocs/op 1237050 ns/op 1091384 B/op 11830 allocs/op 1.05
BenchmarkDocument/array_1000 - ns/op 1300606 ns/op 1237050 ns/op 1.05
BenchmarkDocument/array_1000 - B/op 1091330 B/op 1091384 B/op 1.00
BenchmarkDocument/array_1000 - allocs/op 11829 allocs/op 11830 allocs/op 1.00
BenchmarkDocument/array_10000 14437512 ns/op 9800031 B/op 120295 allocs/op 13842349 ns/op 9799795 B/op 120294 allocs/op 1.04
BenchmarkDocument/array_10000 - ns/op 14437512 ns/op 13842349 ns/op 1.04
BenchmarkDocument/array_10000 - B/op 9800031 B/op 9799795 B/op 1.00
BenchmarkDocument/array_10000 - allocs/op 120295 allocs/op 120294 allocs/op 1.00
BenchmarkDocument/array_gc_100 157008 ns/op 132644 B/op 1258 allocs/op 151286 ns/op 132663 B/op 1259 allocs/op 1.04
BenchmarkDocument/array_gc_100 - ns/op 157008 ns/op 151286 ns/op 1.04
BenchmarkDocument/array_gc_100 - B/op 132644 B/op 132663 B/op 1.00
BenchmarkDocument/array_gc_100 - allocs/op 1258 allocs/op 1259 allocs/op 1.00
BenchmarkDocument/array_gc_1000 1524585 ns/op 1159079 B/op 12874 allocs/op 1458496 ns/op 1159149 B/op 12875 allocs/op 1.05
BenchmarkDocument/array_gc_1000 - ns/op 1524585 ns/op 1458496 ns/op 1.05
BenchmarkDocument/array_gc_1000 - B/op 1159079 B/op 1159149 B/op 1.00
BenchmarkDocument/array_gc_1000 - allocs/op 12874 allocs/op 12875 allocs/op 1.00
BenchmarkDocument/counter_1000 225549 ns/op 193013 B/op 5769 allocs/op 201967 ns/op 193013 B/op 5769 allocs/op 1.12
BenchmarkDocument/counter_1000 - ns/op 225549 ns/op 201967 ns/op 1.12
BenchmarkDocument/counter_1000 - B/op 193013 B/op 193013 B/op 1
BenchmarkDocument/counter_1000 - allocs/op 5769 allocs/op 5769 allocs/op 1
BenchmarkDocument/counter_10000 2452026 ns/op 2087930 B/op 59776 allocs/op 2217629 ns/op 2087927 B/op 59776 allocs/op 1.11
BenchmarkDocument/counter_10000 - ns/op 2452026 ns/op 2217629 ns/op 1.11
BenchmarkDocument/counter_10000 - B/op 2087930 B/op 2087927 B/op 1.00
BenchmarkDocument/counter_10000 - allocs/op 59776 allocs/op 59776 allocs/op 1
BenchmarkDocument/object_1000 1478172 ns/op 1427745 B/op 9846 allocs/op 1358095 ns/op 1428078 B/op 9847 allocs/op 1.09
BenchmarkDocument/object_1000 - ns/op 1478172 ns/op 1358095 ns/op 1.09
BenchmarkDocument/object_1000 - B/op 1427745 B/op 1428078 B/op 1.00
BenchmarkDocument/object_1000 - allocs/op 9846 allocs/op 9847 allocs/op 1.00
BenchmarkDocument/object_10000 16460465 ns/op 12166852 B/op 100562 allocs/op 15872056 ns/op 12164805 B/op 100556 allocs/op 1.04
BenchmarkDocument/object_10000 - ns/op 16460465 ns/op 15872056 ns/op 1.04
BenchmarkDocument/object_10000 - B/op 12166852 B/op 12164805 B/op 1.00
BenchmarkDocument/object_10000 - allocs/op 100562 allocs/op 100556 allocs/op 1.00
BenchmarkDocument/tree_100 1089848 ns/op 943636 B/op 6099 allocs/op 1023258 ns/op 943642 B/op 6099 allocs/op 1.07
BenchmarkDocument/tree_100 - ns/op 1089848 ns/op 1023258 ns/op 1.07
BenchmarkDocument/tree_100 - B/op 943636 B/op 943642 B/op 1.00
BenchmarkDocument/tree_100 - allocs/op 6099 allocs/op 6099 allocs/op 1
BenchmarkDocument/tree_1000 85169669 ns/op 86460540 B/op 60113 allocs/op 74051345 ns/op 86460276 B/op 60113 allocs/op 1.15
BenchmarkDocument/tree_1000 - ns/op 85169669 ns/op 74051345 ns/op 1.15
BenchmarkDocument/tree_1000 - B/op 86460540 B/op 86460276 B/op 1.00
BenchmarkDocument/tree_1000 - allocs/op 60113 allocs/op 60113 allocs/op 1
BenchmarkDocument/tree_10000 11028632722 ns/op 8581000592 B/op 600251 allocs/op 9928184273 ns/op 8580660336 B/op 600220 allocs/op 1.11
BenchmarkDocument/tree_10000 - ns/op 11028632722 ns/op 9928184273 ns/op 1.11
BenchmarkDocument/tree_10000 - B/op 8581000592 B/op 8580660336 B/op 1.00
BenchmarkDocument/tree_10000 - allocs/op 600251 allocs/op 600220 allocs/op 1.00
BenchmarkDocument/tree_delete_all_1000 87854095 ns/op 87509390 B/op 75261 allocs/op 74864903 ns/op 87510751 B/op 75265 allocs/op 1.17
BenchmarkDocument/tree_delete_all_1000 - ns/op 87854095 ns/op 74864903 ns/op 1.17
BenchmarkDocument/tree_delete_all_1000 - B/op 87509390 B/op 87510751 B/op 1.00
BenchmarkDocument/tree_delete_all_1000 - allocs/op 75261 allocs/op 75265 allocs/op 1.00
BenchmarkDocument/tree_edit_gc_100 4240426 ns/op 4146624 B/op 15138 allocs/op 3851970 ns/op 4147739 B/op 15139 allocs/op 1.10
BenchmarkDocument/tree_edit_gc_100 - ns/op 4240426 ns/op 3851970 ns/op 1.10
BenchmarkDocument/tree_edit_gc_100 - B/op 4146624 B/op 4147739 B/op 1.00
BenchmarkDocument/tree_edit_gc_100 - allocs/op 15138 allocs/op 15139 allocs/op 1.00
BenchmarkDocument/tree_edit_gc_1000 337260641 ns/op 383746616 B/op 154845 allocs/op 305522391 ns/op 383746708 B/op 154846 allocs/op 1.10
BenchmarkDocument/tree_edit_gc_1000 - ns/op 337260641 ns/op 305522391 ns/op 1.10
BenchmarkDocument/tree_edit_gc_1000 - B/op 383746616 B/op 383746708 B/op 1.00
BenchmarkDocument/tree_edit_gc_1000 - allocs/op 154845 allocs/op 154846 allocs/op 1.00
BenchmarkDocument/tree_split_gc_100 2804072 ns/op 2412411 B/op 11123 allocs/op 2537492 ns/op 2412465 B/op 11123 allocs/op 1.11
BenchmarkDocument/tree_split_gc_100 - ns/op 2804072 ns/op 2537492 ns/op 1.11
BenchmarkDocument/tree_split_gc_100 - B/op 2412411 B/op 2412465 B/op 1.00
BenchmarkDocument/tree_split_gc_100 - allocs/op 11123 allocs/op 11123 allocs/op 1
BenchmarkDocument/tree_split_gc_1000 205481579 ns/op 222253395 B/op 121989 allocs/op 187850859 ns/op 222251185 B/op 121985 allocs/op 1.09
BenchmarkDocument/tree_split_gc_1000 - ns/op 205481579 ns/op 187850859 ns/op 1.09
BenchmarkDocument/tree_split_gc_1000 - B/op 222253395 B/op 222251185 B/op 1.00
BenchmarkDocument/tree_split_gc_1000 - allocs/op 121989 allocs/op 121985 allocs/op 1.00
BenchmarkRPC/client_to_server 399963446 ns/op 17369229 B/op 174527 allocs/op 394749486 ns/op 16810850 B/op 173459 allocs/op 1.01
BenchmarkRPC/client_to_server - ns/op 399963446 ns/op 394749486 ns/op 1.01
BenchmarkRPC/client_to_server - B/op 17369229 B/op 16810850 B/op 1.03
BenchmarkRPC/client_to_server - allocs/op 174527 allocs/op 173459 allocs/op 1.01
BenchmarkRPC/client_to_client_via_server 667227074 ns/op 33567644 B/op 319347 allocs/op 660340842 ns/op 33524504 B/op 317537 allocs/op 1.01
BenchmarkRPC/client_to_client_via_server - ns/op 667227074 ns/op 660340842 ns/op 1.01
BenchmarkRPC/client_to_client_via_server - B/op 33567644 B/op 33524504 B/op 1.00
BenchmarkRPC/client_to_client_via_server - allocs/op 319347 allocs/op 317537 allocs/op 1.01
BenchmarkRPC/attach_large_document 1575040060 ns/op 1919838848 B/op 8871 allocs/op 1525098895 ns/op 1907764480 B/op 8809 allocs/op 1.03
BenchmarkRPC/attach_large_document - ns/op 1575040060 ns/op 1525098895 ns/op 1.03
BenchmarkRPC/attach_large_document - B/op 1919838848 B/op 1907764480 B/op 1.01
BenchmarkRPC/attach_large_document - allocs/op 8871 allocs/op 8809 allocs/op 1.01
BenchmarkRPC/adminCli_to_server 572349926 ns/op 36780092 B/op 289563 allocs/op 559488376 ns/op 36338804 B/op 288509 allocs/op 1.02
BenchmarkRPC/adminCli_to_server - ns/op 572349926 ns/op 559488376 ns/op 1.02
BenchmarkRPC/adminCli_to_server - B/op 36780092 B/op 36338804 B/op 1.01
BenchmarkRPC/adminCli_to_server - allocs/op 289563 allocs/op 288509 allocs/op 1.00
BenchmarkLocker 67.64 ns/op 16 B/op 1 allocs/op 63.66 ns/op 16 B/op 1 allocs/op 1.06
BenchmarkLocker - ns/op 67.64 ns/op 63.66 ns/op 1.06
BenchmarkLocker - B/op 16 B/op 16 B/op 1
BenchmarkLocker - allocs/op 1 allocs/op 1 allocs/op 1
BenchmarkLockerParallel 44.95 ns/op 0 B/op 0 allocs/op 39.71 ns/op 0 B/op 0 allocs/op 1.13
BenchmarkLockerParallel - ns/op 44.95 ns/op 39.71 ns/op 1.13
BenchmarkLockerParallel - B/op 0 B/op 0 B/op 1
BenchmarkLockerParallel - allocs/op 0 allocs/op 0 allocs/op 1
BenchmarkLockerMoreKeys 159.9 ns/op 15 B/op 0 allocs/op 146.2 ns/op 15 B/op 0 allocs/op 1.09
BenchmarkLockerMoreKeys - ns/op 159.9 ns/op 146.2 ns/op 1.09
BenchmarkLockerMoreKeys - B/op 15 B/op 15 B/op 1
BenchmarkLockerMoreKeys - allocs/op 0 allocs/op 0 allocs/op 1
BenchmarkChange/Push_10_Changes 4286644 ns/op 120661 B/op 1285 allocs/op 4003509 ns/op 121156 B/op 1278 allocs/op 1.07
BenchmarkChange/Push_10_Changes - ns/op 4286644 ns/op 4003509 ns/op 1.07
BenchmarkChange/Push_10_Changes - B/op 120661 B/op 121156 B/op 1.00
BenchmarkChange/Push_10_Changes - allocs/op 1285 allocs/op 1278 allocs/op 1.01
BenchmarkChange/Push_100_Changes 15672740 ns/op 567509 B/op 6656 allocs/op 14882686 ns/op 574414 B/op 6649 allocs/op 1.05
BenchmarkChange/Push_100_Changes - ns/op 15672740 ns/op 14882686 ns/op 1.05
BenchmarkChange/Push_100_Changes - B/op 567509 B/op 574414 B/op 0.99
BenchmarkChange/Push_100_Changes - allocs/op 6656 allocs/op 6649 allocs/op 1.00
BenchmarkChange/Push_1000_Changes 125191411 ns/op 5179388 B/op 63150 allocs/op 118961824 ns/op 5303536 B/op 63147 allocs/op 1.05
BenchmarkChange/Push_1000_Changes - ns/op 125191411 ns/op 118961824 ns/op 1.05
BenchmarkChange/Push_1000_Changes - B/op 5179388 B/op 5303536 B/op 0.98
BenchmarkChange/Push_1000_Changes - allocs/op 63150 allocs/op 63147 allocs/op 1.00
BenchmarkChange/Pull_10_Changes 3096613 ns/op 99615 B/op 1004 allocs/op 2980506 ns/op 100295 B/op 1005 allocs/op 1.04
BenchmarkChange/Pull_10_Changes - ns/op 3096613 ns/op 2980506 ns/op 1.04
BenchmarkChange/Pull_10_Changes - B/op 99615 B/op 100295 B/op 0.99
BenchmarkChange/Pull_10_Changes - allocs/op 1004 allocs/op 1005 allocs/op 1.00
BenchmarkChange/Pull_100_Changes 4819287 ns/op 262600 B/op 3474 allocs/op 4466219 ns/op 264971 B/op 3476 allocs/op 1.08
BenchmarkChange/Pull_100_Changes - ns/op 4819287 ns/op 4466219 ns/op 1.08
BenchmarkChange/Pull_100_Changes - B/op 262600 B/op 264971 B/op 0.99
BenchmarkChange/Pull_100_Changes - allocs/op 3474 allocs/op 3476 allocs/op 1.00
BenchmarkChange/Pull_1000_Changes 10384503 ns/op 1472174 B/op 29768 allocs/op 9059199 ns/op 1489165 B/op 29853 allocs/op 1.15
BenchmarkChange/Pull_1000_Changes - ns/op 10384503 ns/op 9059199 ns/op 1.15
BenchmarkChange/Pull_1000_Changes - B/op 1472174 B/op 1489165 B/op 0.99
BenchmarkChange/Pull_1000_Changes - allocs/op 29768 allocs/op 29853 allocs/op 1.00
BenchmarkSnapshot/Push_3KB_snapshot 18214826 ns/op 692154 B/op 6659 allocs/op 17473824 ns/op 712454 B/op 6659 allocs/op 1.04
BenchmarkSnapshot/Push_3KB_snapshot - ns/op 18214826 ns/op 17473824 ns/op 1.04
BenchmarkSnapshot/Push_3KB_snapshot - B/op 692154 B/op 712454 B/op 0.97
BenchmarkSnapshot/Push_3KB_snapshot - allocs/op 6659 allocs/op 6659 allocs/op 1
BenchmarkSnapshot/Push_30KB_snapshot 126136334 ns/op 5810049 B/op 63157 allocs/op 122099724 ns/op 5545741 B/op 63155 allocs/op 1.03
BenchmarkSnapshot/Push_30KB_snapshot - ns/op 126136334 ns/op 122099724 ns/op 1.03
BenchmarkSnapshot/Push_30KB_snapshot - B/op 5810049 B/op 5545741 B/op 1.05
BenchmarkSnapshot/Push_30KB_snapshot - allocs/op 63157 allocs/op 63155 allocs/op 1.00
BenchmarkSnapshot/Pull_3KB_snapshot 6791860 ns/op 904387 B/op 15509 allocs/op 6608019 ns/op 920705 B/op 15511 allocs/op 1.03
BenchmarkSnapshot/Pull_3KB_snapshot - ns/op 6791860 ns/op 6608019 ns/op 1.03
BenchmarkSnapshot/Pull_3KB_snapshot - B/op 904387 B/op 920705 B/op 0.98
BenchmarkSnapshot/Pull_3KB_snapshot - allocs/op 15509 allocs/op 15511 allocs/op 1.00
BenchmarkSnapshot/Pull_30KB_snapshot 18528909 ns/op 7136260 B/op 150107 allocs/op 15478479 ns/op 7150762 B/op 150109 allocs/op 1.20
BenchmarkSnapshot/Pull_30KB_snapshot - ns/op 18528909 ns/op 15478479 ns/op 1.20
BenchmarkSnapshot/Pull_30KB_snapshot - B/op 7136260 B/op 7150762 B/op 1.00
BenchmarkSnapshot/Pull_30KB_snapshot - allocs/op 150107 allocs/op 150109 allocs/op 1.00
BenchmarkSync/memory_sync_10_test 7428 ns/op 1286 B/op 38 allocs/op 8331 ns/op 1287 B/op 38 allocs/op 0.89
BenchmarkSync/memory_sync_10_test - ns/op 7428 ns/op 8331 ns/op 0.89
BenchmarkSync/memory_sync_10_test - B/op 1286 B/op 1287 B/op 1.00
BenchmarkSync/memory_sync_10_test - allocs/op 38 allocs/op 38 allocs/op 1
BenchmarkSync/memory_sync_100_test 54536 ns/op 8621 B/op 272 allocs/op 57613 ns/op 8972 B/op 294 allocs/op 0.95
BenchmarkSync/memory_sync_100_test - ns/op 54536 ns/op 57613 ns/op 0.95
BenchmarkSync/memory_sync_100_test - B/op 8621 B/op 8972 B/op 0.96
BenchmarkSync/memory_sync_100_test - allocs/op 272 allocs/op 294 allocs/op 0.93
BenchmarkSync/memory_sync_1000_test 595987 ns/op 74168 B/op 2107 allocs/op 413960 ns/op 82895 B/op 2654 allocs/op 1.44
BenchmarkSync/memory_sync_1000_test - ns/op 595987 ns/op 413960 ns/op 1.44
BenchmarkSync/memory_sync_1000_test - B/op 74168 B/op 82895 B/op 0.89
BenchmarkSync/memory_sync_1000_test - allocs/op 2107 allocs/op 2654 allocs/op 0.79
BenchmarkSync/memory_sync_10000_test 8482205 ns/op 741128 B/op 20348 allocs/op 4439019 ns/op 799151 B/op 24004 allocs/op 1.91
BenchmarkSync/memory_sync_10000_test - ns/op 8482205 ns/op 4439019 ns/op 1.91
BenchmarkSync/memory_sync_10000_test - B/op 741128 B/op 799151 B/op 0.93
BenchmarkSync/memory_sync_10000_test - allocs/op 20348 allocs/op 24004 allocs/op 0.85
BenchmarkTextEditing 5548745195 ns/op 3901859616 B/op 18742987 allocs/op 5347439547 ns/op 3901992816 B/op 18743629 allocs/op 1.04
BenchmarkTextEditing - ns/op 5548745195 ns/op 5347439547 ns/op 1.04
BenchmarkTextEditing - B/op 3901859616 B/op 3901992816 B/op 1.00
BenchmarkTextEditing - allocs/op 18742987 allocs/op 18743629 allocs/op 1.00

This comment was automatically generated by workflow using github-action-benchmark.

hackerwins
hackerwins approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit 77e7d16 into main May 24, 2024
4 checks passed
@hackerwins hackerwins deleted the add-resource-limit-in-yorkie-mongodb branch May 24, 2024 01:14
@BrewTestBot BrewTestBot mentioned this pull request May 24, 2024
Merged
@sejongk sejongk mentioned this pull request May 25, 2024
Open
@coderabbitai coderabbitai bot mentioned this pull request Oct 9, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@hackerwins hackerwins hackerwins approved these changes

@sejongk sejongk Awaiting requested review from sejongk

Assignees

@krapie krapie

Labels
enhancement 🌟 New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krapie @hackerwins