Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle concurrent editing and styling in Tree #854

Merged
merged 1 commit into from
May 8, 2024

Conversation

hackerwins
Copy link
Member

@hackerwins hackerwins commented May 8, 2024

What this PR does / why we need it:

Handle concurrent editing and styling in Tree

We will use maxCreatedAtMapByActor until the introduction of VersionVector.

Which issue(s) this PR fixes:

Address #788

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 50.81%. Comparing base (a82995b) to head (1dea4eb).

Files Patch % Lines
pkg/document/crdt/tree.go 63.26% 17 Missing and 1 partial ⚠️
api/converter/to_pb.go 20.00% 8 Missing ⚠️
api/converter/from_pb.go 0.00% 7 Missing ⚠️
pkg/document/crdt/rga_tree_split.go 80.00% 3 Missing ⚠️
pkg/document/crdt/text.go 70.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #854      +/-   ##
==========================================
- Coverage   50.81%   50.81%   -0.01%     
==========================================
  Files          70       70              
  Lines       10255    10285      +30     
==========================================
+ Hits         5211     5226      +15     
- Misses       4516     4530      +14     
- Partials      528      529       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hackerwins hackerwins marked this pull request as ready for review May 8, 2024 08:44
@hackerwins hackerwins merged commit 5a77d08 into main May 8, 2024
4 checks passed
@hackerwins hackerwins deleted the concurrent-tree-style branch May 8, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant