Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move istio-ingressgateway to Yorkie Namespace #836

Merged
merged 1 commit into from
Apr 6, 2024
Merged

Conversation

krapie
Copy link
Member

@krapie krapie commented Apr 6, 2024

What this PR does / why we need it:

Relocate the istio-ingressgateway to the yorkie namespace under the name yorkie-gateway.

The purpose of this move is to clearly segregate yorkie-related Kubernetes resources from other services for better organization and management.

Additionally, for production Istio deployments, it is crucial to separate the istio-ingressgateway and istiod components to enable independent operation.

In Istio, this gateway topology is called Dedicated application gateway.

image

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@krapie krapie added the enhancement 🌟 New feature or request label Apr 6, 2024
@krapie krapie requested a review from hackerwins April 6, 2024 07:38
@krapie krapie self-assigned this Apr 6, 2024
Copy link

codecov bot commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.95%. Comparing base (d5bc939) to head (50cddd9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #836   +/-   ##
=======================================
  Coverage   50.95%   50.95%           
=======================================
  Files          70       70           
  Lines       10226    10226           
=======================================
  Hits         5211     5211           
  Misses       4487     4487           
  Partials      528      528           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

@hackerwins hackerwins merged commit 51a5252 into main Apr 6, 2024
4 checks passed
@hackerwins hackerwins deleted the set-yorkie-gateway branch April 6, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🌟 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants