-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RHT.Remove and Add test code #752
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #752 +/- ##
==========================================
+ Coverage 49.30% 49.48% +0.17%
==========================================
Files 69 69
Lines 10094 10099 +5
==========================================
+ Hits 4977 4997 +20
+ Misses 4601 4587 -14
+ Partials 516 515 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
Overall looks good. I left a simple question.
33b6357
to
080822a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
What this PR does / why we need it:
RHT.Remove
.RHT.Len
to exclude the removed elements.RHT.Nodes
to exclude the removed elements.RHT.Set
when modifying an already deleted key.Related to #748
Which issue(s) this PR fixes:
Fixes #
Checklist: