Fix getGarbageLen to retrun correct size
#743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To correct a mislinked hyperlink for the HELM Chart file line within the `MAINTAINING.md` file.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #743 +/- ##
==========================================
+ Coverage 49.25% 49.27% +0.01%
==========================================
Files 69 69
Lines 10084 10087 +3
==========================================
+ Hits 4967 4970 +3
Misses 4601 4601
Partials 516 516 ☔ View full report in Codecov by Sentry. |
hackerwins
requested changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
GarbageLenfunction returns the correct length, I used a Map to eliminate duplicate countingGarbageLen(same with the test case in this PR)Which issue(s) this PR fixes:
Fixes #688
Special notes for your reviewer:
Refer yorkie-js-sdk/PR #714
The PR solves the same problem. And you can track the optimization history.
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: