Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up golangci-lint and fix lint errors #660

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Conversation

hackerwins
Copy link
Member

@hackerwins hackerwins commented Nov 3, 2023

What this PR does / why we need it:

Bump up golangci-lint and fix lint errors

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@f922afc). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #660   +/-   ##
=======================================
  Coverage        ?   48.93%           
=======================================
  Files           ?       69           
  Lines           ?    10072           
  Branches        ?        0           
=======================================
  Hits            ?     4929           
  Misses          ?     4627           
  Partials        ?      516           
Files Coverage Δ
pkg/document/crdt/text.go 61.90% <100.00%> (ø)
server/backend/database/mongo/client.go 39.58% <100.00%> (ø)
server/backend/sync/memory/coordinator.go 31.25% <ø> (ø)
server/backend/database/memory/database.go 48.09% <66.66%> (ø)
server/backend/sync/memory/locker.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hackerwins hackerwins merged commit 2b3ad30 into main Nov 3, 2023
2 checks passed
@hackerwins hackerwins deleted the bump-up-golangci-lint branch November 3, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant