Remove skip storing MinSyncedTicket when the ticket is initial #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To improve GC efficiency, when a client first attaches a document, if there are no changes in the document, pushing MinSyncedTicket is skipped.
hackerwins
force-pushed
the
remove-skip-min-sync-keys
branch
from
885347c
to
46c0a65
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #655 +/- ##
==========================================
+ Coverage 48.86% 48.89% +0.02%
==========================================
Files 69 69
Lines 10082 10076 -6
==========================================
Hits 4927 4927
+ Misses 4635 4629 -6
Partials 520 520
☔ View full report in Codecov by Sentry. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Remove skip storing MinSyncedTicket when the ticket is initial
Previously, in order to enhance GC efficiency, when a client initially attaches a document that has any changes, the process of storing MinSyncedTicket was skipped. However, this approach is flawed because the server stores the ticket based on the checkpoint of requests for handling scenarios where the client's response may be lost.
So this commit removes the optimization for now.
This commit also revises the logs of the PushPull process to be more simple.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: