Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve CI failure with longer MaxConnectionAge #556

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Conversation

krapie
Copy link
Member

@krapie krapie commented Jun 19, 2023

What this PR does / why we need it:

Resolve CI failure with longer MaxConnectionAge.

This is to resolve intermittent CI failure, with the assumption that the RPC server's short MaxConnectionAge on testing is causing CI failure.

Because this solution is based on an assumption, we need to see whether this change will resolve CI failure or not.

Which issue(s) this PR fixes:

Fixes #546

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@krapie krapie added the bug 🐞 Something isn't working label Jun 19, 2023
@krapie krapie requested a review from hackerwins June 19, 2023 18:43
@krapie krapie self-assigned this Jun 19, 2023
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #556 (672d96c) into main (c081d24) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #556   +/-   ##
=======================================
  Coverage   50.43%   50.43%           
=======================================
  Files          67       67           
  Lines        6763     6763           
=======================================
  Hits         3411     3411           
  Misses       2923     2923           
  Partials      429      429           

Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit 19d87a0 into main Jun 19, 2023
@hackerwins hackerwins deleted the resolve-ci-failure branch June 19, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin RPC test fails intermittently
2 participants