Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove panic method in crdt array #524

Merged
merged 5 commits into from
May 29, 2023
Merged

Remove panic method in crdt array #524

merged 5 commits into from
May 29, 2023

Conversation

emplam27
Copy link
Contributor

Remove panic method in crdt array

  • go sdk crdt array has the condition that cause panic
  • remove panic prevent shutdown server when crdt array error occurred

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #501

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

- go sdk crdt array has the condition that cause panic
- remove panic prevent shutdown server when crdt array error occurred
@emplam27 emplam27 self-assigned this Apr 25, 2023
@hackerwins hackerwins added the cleanup 🧹 Paying off technical debt label Apr 26, 2023
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #524 (3594fb9) into main (8287e05) will decrease coverage by 0.07%.
The diff coverage is 38.70%.

@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
- Coverage   50.34%   50.28%   -0.07%     
==========================================
  Files          65       65              
  Lines        6054     6068      +14     
==========================================
+ Hits         3048     3051       +3     
- Misses       2611     2617       +6     
- Partials      395      400       +5     
Impacted Files Coverage Δ
pkg/document/crdt/text.go 57.84% <ø> (ø)
pkg/document/crdt/array.go 32.07% <25.00%> (-1.97%) ⬇️
pkg/document/crdt/rga_tree_list.go 62.40% <25.00%> (-2.07%) ⬇️
pkg/document/crdt/rga_tree_split.go 69.60% <50.00%> (-1.48%) ⬇️
pkg/splay/splay.go 79.78% <66.66%> (+1.66%) ⬆️

Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit 77d14f0 into main May 29, 2023
@hackerwins hackerwins deleted the remove-panic-crdt-array branch May 29, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup 🧹 Paying off technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants