Remove duplicated backslash in string escaping #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #458 +/- ##
==========================================
+ Coverage 46.47% 46.56% +0.09%
==========================================
Files 70 70
Lines 5730 5723 -7
==========================================
+ Hits 2663 2665 +2
+ Misses 2773 2764 -9
Partials 294 294
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
cozitive
force-pushed
the
string-escape
branch
from
50aa768
to
823ad0c
Compare
cozitive
commented
Feb 8, 2023
| go test -tags bench -benchmem -bench=. ./test/bench -memprofile=mem.prof -cpuprofile=cpu.prof | tee output.txt | ||
| mkfifo pipe | ||
| tee output.txt < pipe & | ||
| go test -tags bench -benchmem -bench=. ./test/bench -memprofile=mem.prof -cpuprofile=cpu.prof > pipe |
There was a problem hiding this comment.
The exit status of benchmark test has been ignored, because the exit status of a pipeline is the exit status of the last command (tee) in the pipeline.
To reveal the original exit status, piping command is separated.
There was a problem hiding this comment.
Thanks for the detailed description.
hackerwins
approved these changes
Feb 9, 2023
| go test -tags bench -benchmem -bench=. ./test/bench -memprofile=mem.prof -cpuprofile=cpu.prof | tee output.txt | ||
| mkfifo pipe | ||
| tee output.txt < pipe & | ||
| go test -tags bench -benchmem -bench=. ./test/bench -memprofile=mem.prof -cpuprofile=cpu.prof > pipe |
There was a problem hiding this comment.
Thanks for the detailed description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
At PR #439, I escaped RHT key and value strings to fix issue #437.
When checking
EscapeString()function at that time, I thought it should put two backslashes in front of special characters, becauseJSON.stringify()in JavaScript added two backslashes. For example, the return value ofJSON.stringify({"key": "value\n"})is'{"key":"value\\n"}'.However, the additional backslash in the example above is just to represent a single backslash in JS string. Valid JSON string uses only a single backslash for control characters.
Since the updated
EscapeString()makes invalid JSON strings, it should be reverted.Which issue(s) this PR fixes:
Fixes #439 and #443
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: