Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up codes #440

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Clean up codes #440

merged 1 commit into from
Jan 9, 2023

Conversation

hackerwins
Copy link
Member

@hackerwins hackerwins commented Jan 9, 2023

What this PR does / why we need it:

  • Add the missing unwatchDocs function in WatchDocuments API
  • Extract types.NewAccessAttributes
  • Clean up code that uses magic number

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@hackerwins hackerwins merged commit c8296be into main Jan 9, 2023
@hackerwins hackerwins deleted the cleanup-codes branch January 9, 2023 11:08
hackerwins added a commit that referenced this pull request Jan 12, 2023
- Add the missing `unwatchDocs` function in `WatchDocuments` API
- Extract `types.NewAccessAttributes`
- Clean up code that uses a magic number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant