Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid JSON returned when marshaling dates #432

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Conversation

hackerwins
Copy link
Member

@hackerwins hackerwins commented Nov 24, 2022

What this PR does / why we need it:

Fix invalid JSON returned when marshaling dates.

AS-IS

{
  "date": 2022-11-25T01:15:41+09:00
}

TO-BE

{
  "date": "2022-11-25T01:15:41+09:00"
}

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Merging #432 (5788641) into main (6e5869a) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #432   +/-   ##
=======================================
  Coverage   46.96%   46.96%           
=======================================
  Files          71       71           
  Lines        5913     5913           
=======================================
  Hits         2777     2777           
  Misses       2831     2831           
  Partials      305      305           
Impacted Files Coverage Δ
pkg/document/crdt/primitive.go 96.18% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant