-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store subscription map in etcd #214
Conversation
- Remove WatchStarted type - Returns the second response, if an error occurs before initialization
8b9032b
to
d726de1
Compare
d726de1
to
7f48909
Compare
Codecov Report
@@ Coverage Diff @@
## main #214 +/- ##
==========================================
- Coverage 58.57% 57.85% -0.73%
==========================================
Files 44 44
Lines 3684 3732 +48
==========================================
+ Hits 2158 2159 +1
- Misses 1327 1374 +47
Partials 199 199
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@hackerwins In the future, in cluster mode, do you plan to manage subscriptions only in etcd instead of memory.pubsub? If you could explain a little more why this work is necessary, it would be good for reference in other work in the future. |
I'm still thinking about the following.
|
What this PR does / why we need it:
Store subscription map in etcd.
Which issue(s) this PR fixes:
Fixes #183
Special notes for your reviewer:
We need to merge #213 first.
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: