Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store subscription map in etcd #214

Merged
merged 3 commits into from
Jul 15, 2021
Merged

Store subscription map in etcd #214

merged 3 commits into from
Jul 15, 2021

Conversation

hackerwins
Copy link
Member

@hackerwins hackerwins commented Jul 13, 2021

What this PR does / why we need it:

Store subscription map in etcd.

Which issue(s) this PR fixes:

Fixes #183

Special notes for your reviewer:

We need to merge #213 first.

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

- Remove WatchStarted type
- Returns the second response, if an error occurs before initialization
@hackerwins hackerwins requested a review from a team July 13, 2021 18:56
Base automatically changed from refactor-watch to main July 14, 2021 00:40
@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #214 (7f48909) into main (93abec2) will decrease coverage by 0.72%.
The diff coverage is 1.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
- Coverage   58.57%   57.85%   -0.73%     
==========================================
  Files          44       44              
  Lines        3684     3732      +48     
==========================================
+ Hits         2158     2159       +1     
- Misses       1327     1374      +47     
  Partials      199      199              
Impacted Files Coverage Δ
yorkie/backend/sync/etcd/pubsub.go 0.00% <0.00%> (ø)
yorkie/backend/sync/memory/coordinator.go 0.00% <0.00%> (ø)
yorkie/rpc/yorkie_server.go 45.74% <0.00%> (-0.38%) ⬇️
yorkie/backend/sync/memory/pubsub.go 94.36% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93abec2...7f48909. Read the comment docs.

Copy link
Member

@dc7303 dc7303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dc7303 dc7303 assigned hackerwins and unassigned dc7303 Jul 14, 2021
@dc7303
Copy link
Member

dc7303 commented Jul 14, 2021

@hackerwins In the future, in cluster mode, do you plan to manage subscriptions only in etcd instead of memory.pubsub? If you could explain a little more why this work is necessary, it would be good for reference in other work in the future.

@hackerwins
Copy link
Member Author

I'm still thinking about the following.

  1. SubscriptionMap must remain as it has to manage the channels with the clients.
  2. It seems to be better to move Metadata to MongoDB for metadata updates: Improve Peer Awareness's metadata to be updatable #153.

@hackerwins hackerwins merged commit 3201c71 into main Jul 15, 2021
@hackerwins hackerwins deleted the extract-submap branch July 15, 2021 00:56
jeonjonghyeok pushed a commit to jeonjonghyeok/yorkie that referenced this pull request Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce distributed PubSub
4 participants