Extract MemPubSub from PubSub #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackerwins
force-pushed
the
extract-pubsub-interface
branch
2 times, most recently
from
96fdf4e to
412092f
Compare
Before implementing the distributed PubSub implementation using ETCD, we need to extract the temporarily implemented MemoryPubSub and leave only the high-level abstraction logic in PubSub.
hackerwins
force-pushed
the
extract-pubsub-interface
branch
from
412092f to
d4ca2b4
Compare
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
==========================================
+ Coverage 58.52% 58.59% +0.06%
==========================================
Files 27 27
Lines 2968 2968
==========================================
+ Hits 1737 1739 +2
+ Misses 1057 1056 -1
+ Partials 174 173 -1
Continue to review full report at Codecov.
|
2 tasks
dc7303
suggested changes
Jan 9, 2021
dc7303
approved these changes
Jan 9, 2021
jeonjonghyeok
pushed a commit
to jeonjonghyeok/yorkie
that referenced
this pull request
Aug 4, 2022
Before implementing the distributed PubSub implementation using ETCD, we need to extract the temporarily implemented MemoryPubSub and leave only the high-level abstraction logic in PubSub.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Extract MemPubSub from PubSub
Before implementing the distributed PubSub implementation using ETCD, we
need to extract the temporarily implemented MemoryPubSub and leave only
the high-level abstraction logic in PubSub.
Which issue(s) this PR fixes:
Address #11
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: