-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect indexes in TreeChange #837
Conversation
Warning Review failedThe pull request is closed. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #837 +/- ##
==========================================
+ Coverage 80.45% 80.68% +0.22%
==========================================
Files 59 59
Lines 4543 4576 +33
Branches 921 930 +9
==========================================
+ Hits 3655 3692 +37
+ Misses 619 616 -3
+ Partials 269 268 -1 ☔ View full report in Codecov by Sentry. |
What this PR does / why we need it?
This commit addresses the issue where indexes of TreeChange returned
during Tree.Style are inaccurately calculated. When executing
Tree.Style, users provide a range, but the actual execution is based
on nodes. This commit corrects the calculation of the TreeChange index
by basing it on nodes, resolving the issue.
Any background context you want to provide?
What are the relevant tickets?
Address yorkie-team/yorkie#882
Address yorkie-team/yorkie#884
Related yorkie-team/yorkie-android-sdk#193
Checklist