Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore interface changes due to server DB sharding #740

Merged

Conversation

sejongk
Copy link
Contributor

@sejongk sejongk commented Jan 25, 2024

What this PR does / why we need it?

This commit restores passing sharding keys to the SDK in accordance with yorkie-team/yorkie#776.

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@sejongk sejongk requested a review from hackerwins January 25, 2024 15:25
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit 2882578 into main Jan 26, 2024
2 checks passed
@hackerwins hackerwins deleted the restore-interface-changes-due-to-server-db-sharding branch January 26, 2024 10:41
@hackerwins hackerwins added protocol changed 📝 Whether the protocol has changed sdk ⚒️ labels Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol changed 📝 Whether the protocol has changed sdk ⚒️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants