Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix peer initialization #92

Merged
merged 2 commits into from
Mar 17, 2023
Merged

fix peer initialization #92

merged 2 commits into from
Mar 17, 2023

Conversation

7hong13
Copy link
Contributor

@7hong13 7hong13 commented Mar 17, 2023

What this PR does / why we need it?

It fixes an issue where peer information was not properly reflected in the previous code.

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@7hong13 7hong13 requested a review from skhugh March 17, 2023 05:41
@7hong13 7hong13 self-assigned this Mar 17, 2023
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #92 (103ba1d) into main (a6cb0e8) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   81.93%   81.93%           
=======================================
  Files          52       52           
  Lines        2397     2397           
  Branches      335      335           
=======================================
  Hits         1964     1964           
  Misses        252      252           
  Partials      181      181           
Impacted Files Coverage Δ
yorkie/src/main/kotlin/dev/yorkie/core/Client.kt 87.13% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@7hong13 7hong13 merged commit 89d535f into main Mar 17, 2023
@7hong13 7hong13 deleted the peer_initialization branch March 17, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants