Remove priority queue from RhtPQMap and entire project #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7hong13
commented
Feb 21, 2023
| val node = nodeMapByCreatedAt[createdAt] | ||
| ?: throw NoSuchElementException("The ElementRhtNode by $createdAt doesn't exist.") | ||
| node.remove(executedAt) | ||
| return node.value |
There was a problem hiding this comment.
@hackerwins I returned the node.value regardless of whether or not the node.remove() returned true, based on the JS-SDK.
| val node = nodeMapByKey[key] | ||
| ?: throw NoSuchElementException("$key doesn't exist in nodeMapByKey") | ||
| node.remove(removedAt) | ||
| return node.value |
There was a problem hiding this comment.
@hackerwins I returned the node.value in the same way as the remove() function above. This approach differs slightly from the JS-SDK, so I will adjust it if it could cause any issues.
There was a problem hiding this comment.
fixed it to return nullable value ac9080f
Codecov Report
@@ Coverage Diff @@
## main #84 +/- ##
==========================================
+ Coverage 81.48% 81.80% +0.31%
==========================================
Files 52 52
Lines 2377 2358 -19
Branches 336 334 -2
==========================================
- Hits 1937 1929 -8
+ Misses 257 250 -7
+ Partials 183 179 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
skhugh
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
RhtPQMapto use less memory by removing the priority queue.RhtPQMaphas been renamed toElementRht.Any background context you want to provide?
What are the relevant tickets?
yorkie-team/yorkie#462, yorkie-team/yorkie#423
Checklist