Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deleteRange behavior #81

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Fix deleteRange behavior #81

merged 1 commit into from
Feb 17, 2023

Conversation

skhugh
Copy link
Contributor

@skhugh skhugh commented Feb 17, 2023

What this PR does / why we need it?

Changed deleteRange to cut off target node from the tree, as it can be later requested to be deleted on GC.
Also changed the naming to cutOffRange to better suit the changed behavior.

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@skhugh skhugh self-assigned this Feb 17, 2023
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #81 (1ff6867) into main (f2cf37d) will decrease coverage by 0.03%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   81.40%   81.38%   -0.03%     
==========================================
  Files          52       52              
  Lines        2377     2374       -3     
  Branches      336      336              
==========================================
- Hits         1935     1932       -3     
  Misses        257      257              
  Partials      185      185              
Impacted Files Coverage Δ
...in/kotlin/dev/yorkie/document/crdt/RgaTreeSplit.kt 66.66% <0.00%> (ø)
...ie/src/main/kotlin/dev/yorkie/util/SplayTreeSet.kt 77.94% <100.00%> (-0.32%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit 6a1fd35 into main Feb 17, 2023
@hackerwins hackerwins deleted the fix_splay branch February 17, 2023 04:37
@skhugh skhugh mentioned this pull request Feb 17, 2023
2 tasks
@7hong13 7hong13 mentioned this pull request Feb 21, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants