Make runWatchLoop to react to attachments changes #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Makes
runWatchLoop
to react toattachments
changes.This makes watch loop to keep running while the
client
is active which makes it similar to howrunSyncLoop
runs.Also it removes multiple explicit call-sites of
runWatchLoop
everytime attachments change, which was error-prone.Any background context you want to provide?
What are the relevant tickets?
Fixes #
Checklist