Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make runWatchLoop to react to attachments changes #77

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

skhugh
Copy link
Contributor

@skhugh skhugh commented Feb 8, 2023

What this PR does / why we need it?

Makes runWatchLoop to react to attachments changes.
This makes watch loop to keep running while the client is active which makes it similar to how runSyncLoop runs.
Also it removes multiple explicit call-sites of runWatchLoop everytime attachments change, which was error-prone.

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@skhugh skhugh self-assigned this Feb 8, 2023
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #77 (ab14eb2) into main (c194956) will increase coverage by 0.17%.
The diff coverage is 82.14%.

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   80.97%   81.14%   +0.17%     
==========================================
  Files          52       52              
  Lines        2370     2371       +1     
  Branches      337      336       -1     
==========================================
+ Hits         1919     1924       +5     
+ Misses        260      258       -2     
+ Partials      191      189       -2     
Impacted Files Coverage Δ
...in/kotlin/dev/yorkie/document/crdt/RgaTreeSplit.kt 65.53% <80.00%> (ø)
yorkie/src/main/kotlin/dev/yorkie/core/Client.kt 86.44% <80.43%> (+1.63%) ⬆️
...rkie/src/main/kotlin/dev/yorkie/core/Attachment.kt 100.00% <100.00%> (ø)
...main/kotlin/dev/yorkie/document/crdt/CrdtObject.kt 90.69% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit 4a956b0 into main Feb 8, 2023
@hackerwins hackerwins deleted the watch_loop_change branch February 8, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants