Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicated key from TextNodeAttr. #69

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Conversation

skhugh
Copy link
Contributor

@skhugh skhugh commented Jan 13, 2023

What this PR does / why we need it?

Any background context you want to provide?

remove duplicated key from TextNodeAttr.

What are the relevant tickets?

Address yorkie-team/yorkie#445, yorkie-team/yorkie#435 (comment)

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@skhugh skhugh self-assigned this Jan 13, 2023
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #69 (7d4fd2e) into main (a29ef7a) will increase coverage by 0.03%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   81.05%   81.09%   +0.03%     
==========================================
  Files          52       52              
  Lines        2349     2348       -1     
  Branches      336      336              
==========================================
  Hits         1904     1904              
+ Misses        256      255       -1     
  Partials      189      189              
Impacted Files Coverage Δ
...src/main/kotlin/dev/yorkie/api/ElementConverter.kt 77.57% <50.00%> (+0.36%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hackerwins hackerwins merged commit 9562b3d into main Jan 13, 2023
@hackerwins hackerwins deleted the fix_text_node_Attr branch January 13, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants