Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement JsonText #66

Merged
merged 8 commits into from
Jan 11, 2023
Merged

Implement JsonText #66

merged 8 commits into from
Jan 11, 2023

Conversation

7hong13
Copy link
Contributor

@7hong13 7hong13 commented Jan 10, 2023

What this PR does / why we need it?

Implement JsonText.

Any background context you want to provide?

I removed createRange() function in JS-SDK version since it seems unnecessary.

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@7hong13 7hong13 self-assigned this Jan 10, 2023
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #66 (93338df) into main (e3fe2ca) will increase coverage by 2.08%.
The diff coverage is 87.83%.

@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   78.94%   81.02%   +2.08%     
==========================================
  Files          51       52       +1     
  Lines        2289     2345      +56     
  Branches      334      335       +1     
==========================================
+ Hits         1807     1900      +93     
+ Misses        296      257      -39     
- Partials      186      188       +2     
Impacted Files Coverage Δ
...in/kotlin/dev/yorkie/document/crdt/RgaTreeSplit.kt 65.88% <0.00%> (+3.92%) ⬆️
...ain/kotlin/dev/yorkie/document/json/JsonCounter.kt 93.33% <ø> (ø)
...c/main/kotlin/dev/yorkie/document/json/JsonText.kt 84.31% <84.31%> (ø)
...c/main/kotlin/dev/yorkie/api/OperationConverter.kt 100.00% <100.00%> (ø)
...kotlin/dev/yorkie/document/change/ChangeContext.kt 95.00% <100.00%> (+0.55%) ⬆️
...c/main/kotlin/dev/yorkie/document/crdt/TextInfo.kt 92.59% <100.00%> (ø)
...ain/kotlin/dev/yorkie/document/json/JsonElement.kt 88.88% <100.00%> (+13.88%) ⬆️
...main/kotlin/dev/yorkie/document/json/JsonObject.kt 91.89% <100.00%> (+0.34%) ⬆️
...lin/dev/yorkie/document/operation/EditOperation.kt 75.00% <100.00%> (+35.00%) ⬆️
yorkie/src/main/kotlin/dev/yorkie/core/Client.kt 84.81% <0.00%> (+0.42%) ⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit 936663b into main Jan 11, 2023
@hackerwins hackerwins deleted the json_text branch January 11, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants