Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement max priority queue #5

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Implement max priority queue #5

merged 1 commit into from
Sep 8, 2022

Conversation

skhugh
Copy link
Contributor

@skhugh skhugh commented Sep 8, 2022 •
edited
Loading

What this PR does / why we need it?

Implements a max priority queue.

Any background context you want to provide?

MaxPriorityQueue is an equivalent of Heap in yorkie-js-sdk.

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@skhugh skhugh self-assigned this Sep 8, 2022
hackerwins
hackerwins approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution.

@hackerwins hackerwins merged commit c606c36 into main Sep 8, 2022
@hackerwins hackerwins deleted the heap branch September 8, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hackerwins hackerwins hackerwins approved these changes

@7hong13 7hong13 Awaiting requested review from 7hong13

@daeyounglnc daeyounglnc Awaiting requested review from daeyounglnc

Assignees

@skhugh skhugh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skhugh @hackerwins