-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement JsonCounter and change CrdtCounter structure #49
Conversation
Codecov Report
@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 78.59% 79.92% +1.32%
==========================================
Files 44 45 +1
Lines 1733 1758 +25
Branches 250 250
==========================================
+ Hits 1362 1405 +43
+ Misses 232 206 -26
- Partials 139 147 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@@ -250,8 +248,10 @@ internal fun PBJsonElementSimple.toCrdtElement(): CrdtElement { | |||
) | |||
PBValueType.VALUE_TYPE_INTEGER_CNT, | |||
PBValueType.VALUE_TYPE_DOUBLE_CNT, | |||
PBValueType.VALUE_TYPE_LONG_CNT, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you meant to delete the double type here :)
since we are only allowing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
What this PR does / why we need it?
Implemented JsonCounter and changed CrdtCounter a bit.
(more test code to be added on JsonCounter)
Any background context you want to provide?
changes on CrdtCounter
Double
type is not supported.What are the relevant tickets?
Fixes #
Checklist