Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add instrumented test #44

Merged
merged 2 commits into from
Nov 8, 2022
Merged

add instrumented test #44

merged 2 commits into from
Nov 8, 2022

Conversation

skhugh
Copy link
Contributor

@skhugh skhugh commented Nov 7, 2022

What this PR does / why we need it?

Any background context you want to provide?

added instrumentet test to verify it is properly synced when multiple clients work on same document.

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@skhugh skhugh self-assigned this Nov 7, 2022
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #44 (59f7df9) into main (2cb827e) will increase coverage by 1.39%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main      #44      +/-   ##
============================================
+ Coverage     77.61%   79.00%   +1.39%     
============================================
  Files            44       44              
  Lines          1724     1724              
  Branches        250      250              
============================================
+ Hits           1338     1362      +24     
+ Misses          250      223      -27     
- Partials        136      139       +3     
Impacted Files Coverage Δ
yorkie/src/main/kotlin/dev/yorkie/core/Client.kt 84.81% <100.00%> (+4.89%) ⬆️
...ie/src/main/kotlin/dev/yorkie/document/Document.kt 87.87% <100.00%> (+1.28%) ⬆️
...c/main/kotlin/dev/yorkie/document/crdt/CrdtRoot.kt 65.85% <0.00%> (+7.31%) ⬆️
...main/kotlin/dev/yorkie/document/change/ChangeID.kt 90.90% <0.00%> (+9.09%) ⬆️
...in/kotlin/dev/yorkie/document/change/CheckPoint.kt 100.00% <0.00%> (+33.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. 👍

@hackerwins hackerwins merged commit 0ba49b3 into main Nov 8, 2022
@hackerwins hackerwins deleted the instrumented_test branch November 8, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants