Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

few improvements here and there. #43

Merged
merged 2 commits into from
Nov 3, 2022
Merged

few improvements here and there. #43

merged 2 commits into from
Nov 3, 2022

Conversation

skhugh
Copy link
Contributor

@skhugh skhugh commented Nov 3, 2022

What this PR does / why we need it?

some name changes.
fix TimeTicket comparison error.
use ByteString instead of ByteArray in CrdtPrimitive. (becuase ByteArray does not provide a useful equals)

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

some name changes.
fix TimeTicket comparison error.
use ByteString instead of ByteArray in CrdtPrimitive.
@skhugh skhugh self-assigned this Nov 3, 2022
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #43 (6a43ed2) into main (306d047) will increase coverage by 1.40%.
The diff coverage is 90.22%.

@@             Coverage Diff              @@
##               main      #43      +/-   ##
============================================
+ Coverage     76.20%   77.61%   +1.40%     
- Complexity      376      390      +14     
============================================
  Files            44       44              
  Lines          1685     1724      +39     
  Branches        241      250       +9     
============================================
+ Hits           1284     1338      +54     
+ Misses          263      250      -13     
+ Partials        138      136       -2     
Impacted Files Coverage Δ
...c/main/kotlin/dev/yorkie/document/crdt/CrdtRoot.kt 58.53% <0.00%> (ø)
...kotlin/dev/yorkie/document/crdt/CrdtTextElement.kt 0.00% <ø> (ø)
...n/dev/yorkie/document/operation/RemoveOperation.kt 71.42% <ø> (+4.76%) ⬆️
...n/kotlin/dev/yorkie/document/json/JsonPrimitive.kt 46.66% <12.50%> (+26.66%) ⬆️
.../main/kotlin/dev/yorkie/document/crdt/CrdtArray.kt 76.08% <60.00%> (+0.53%) ⬆️
...main/kotlin/dev/yorkie/document/json/JsonObject.kt 90.62% <87.50%> (+1.15%) ⬆️
...n/kotlin/dev/yorkie/document/crdt/CrdtPrimitive.kt 96.10% <96.96%> (+0.54%) ⬆️
...src/main/kotlin/dev/yorkie/api/ElementConverter.kt 55.47% <100.00%> (ø)
...in/kotlin/dev/yorkie/document/change/CheckPoint.kt 66.66% <100.00%> (ø)
...ain/kotlin/dev/yorkie/document/crdt/CrdtCounter.kt 93.87% <100.00%> (+2.04%) ⬆️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit 2cb827e into main Nov 3, 2022
@hackerwins hackerwins deleted the misc branch November 3, 2022 13:36
skhugh added a commit that referenced this pull request Nov 8, 2022
* Few improvements here and there

Some name changes.
Fix TimeTicket comparison error.
Use ByteString instead of ByteArray in CrdtPrimitive.

* Add more tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants