Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make CrdtElements and Operations data class. #40

Merged
merged 2 commits into from
Nov 3, 2022
Merged

make CrdtElements and Operations data class. #40

merged 2 commits into from
Nov 3, 2022

Conversation

skhugh
Copy link
Contributor

@skhugh skhugh commented Nov 2, 2022

What this PR does / why we need it?

made some misc improvements.
make CrdtElements and Operations data class for better copying and constructions.
fix authInterceptor null issue.

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

fix authInterceptor null issue.
@skhugh skhugh self-assigned this Nov 2, 2022
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #40 (d785465) into main (e18bfe2) will decrease coverage by 0.21%.
The diff coverage is 79.59%.

@@             Coverage Diff              @@
##               main      #40      +/-   ##
============================================
- Coverage     75.65%   75.43%   -0.22%     
+ Complexity      369      366       -3     
============================================
  Files            43       43              
  Lines          1614     1657      +43     
  Branches        230      233       +3     
============================================
+ Hits           1221     1250      +29     
- Misses          259      273      +14     
  Partials        134      134              
Impacted Files Coverage Δ
...src/main/kotlin/dev/yorkie/core/AuthInterceptor.kt 10.00% <0.00%> (-2.50%) ⬇️
...kotlin/dev/yorkie/document/crdt/CrdtTextElement.kt 0.00% <0.00%> (ø)
...c/main/kotlin/dev/yorkie/document/crdt/RhtPQMap.kt 79.71% <0.00%> (-4.91%) ⬇️
.../main/kotlin/dev/yorkie/document/json/JsonArray.kt 59.25% <0.00%> (ø)
...src/main/kotlin/dev/yorkie/api/ElementConverter.kt 55.47% <47.61%> (-1.57%) ⬇️
...ie/src/main/kotlin/dev/yorkie/util/SplayTreeSet.kt 77.18% <66.66%> (ø)
...ain/kotlin/dev/yorkie/document/crdt/RgaTreeList.kt 76.63% <82.75%> (-2.37%) ⬇️
...ain/kotlin/dev/yorkie/document/crdt/CrdtElement.kt 77.77% <83.33%> (-8.89%) ⬇️
...ain/kotlin/dev/yorkie/document/crdt/CrdtCounter.kt 90.00% <92.30%> (ø)
...ie/src/main/kotlin/dev/yorkie/document/Document.kt 86.59% <100.00%> (ø)
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. 👍

@hackerwins hackerwins merged commit 7dd00c6 into main Nov 3, 2022
@hackerwins hackerwins deleted the misc branch November 3, 2022 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants