Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement JsonPrimitive #26

Merged
merged 1 commit into from
Oct 21, 2022
Merged

implement JsonPrimitive #26

merged 1 commit into from
Oct 21, 2022

Conversation

skhugh
Copy link
Contributor

@skhugh skhugh commented Oct 20, 2022

What this PR does / why we need it?

Any background context you want to provide?

implements JsonPrimitive to make it easier to handle elements in JsonObject and JsonArray.
also renames Primitive to CrdtPrimitive to prevent confusion.

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@skhugh skhugh self-assigned this Oct 20, 2022
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #26 (6a42e65) into main (f1c5320) will decrease coverage by 0.91%.
The diff coverage is 21.87%.

@@             Coverage Diff              @@
##               main      #26      +/-   ##
============================================
- Coverage     46.49%   45.57%   -0.92%     
  Complexity      191      191              
============================================
  Files            31       32       +1     
  Lines           942      961      +19     
  Branches        130      132       +2     
============================================
  Hits            438      438              
- Misses          443      462      +19     
  Partials         61       61              
Impacted Files Coverage Δ
...ain/kotlin/dev/yorkie/document/crdt/CrdtCounter.kt 88.37% <ø> (ø)
.../main/kotlin/dev/yorkie/document/json/JsonArray.kt 0.00% <0.00%> (ø)
...ain/kotlin/dev/yorkie/document/json/JsonElement.kt 0.00% <0.00%> (ø)
...main/kotlin/dev/yorkie/document/json/JsonObject.kt 0.00% <0.00%> (ø)
...n/kotlin/dev/yorkie/document/json/JsonPrimitive.kt 0.00% <0.00%> (ø)
...dev/yorkie/document/operation/IncreaseOperation.kt 0.00% <0.00%> (ø)
...n/kotlin/dev/yorkie/document/crdt/CrdtPrimitive.kt 79.16% <100.00%> (ø)
...ain/kotlin/dev/yorkie/document/crdt/RgaTreeList.kt 77.22% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@skhugh skhugh merged commit 3d87ffe into main Oct 21, 2022
@skhugh skhugh deleted the json_element branch October 21, 2022 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants