Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements ChangePack, CheckPoint #25

Merged
merged 3 commits into from
Oct 20, 2022
Merged

Implements ChangePack, CheckPoint #25

merged 3 commits into from
Oct 20, 2022

Conversation

7hong13
Copy link
Contributor

@7hong13 7hong13 commented Oct 19, 2022

What this PR does / why we need it?

Implements ChangePack, CheckPoint.

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@7hong13 7hong13 self-assigned this Oct 19, 2022
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #25 (845b02e) into main (6d1bca1) will decrease coverage by 1.17%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main      #25      +/-   ##
============================================
- Coverage     51.22%   50.05%   -1.18%     
  Complexity      191      191              
============================================
  Files            29       31       +2     
  Lines           855      875      +20     
  Branches        127      127              
============================================
  Hits            438      438              
- Misses          356      376      +20     
  Partials         61       61              
Impacted Files Coverage Δ
...in/kotlin/dev/yorkie/document/change/ChangePack.kt 0.00% <0.00%> (ø)
...in/kotlin/dev/yorkie/document/change/CheckPoint.kt 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.
Please check the comments that @skhugh left.
https://github.com/yorkie-team/yorkie-android-sdk/pull/25/files#r999485530

@hackerwins hackerwins merged commit 4a710ae into main Oct 20, 2022
@hackerwins hackerwins deleted the change branch October 20, 2022 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants