Improve test coverage #19
Conversation
some methods are delayed to be implemented until they are actually needed.
this is done based on the following discussion: yorkie-team/yorkie-ios-sdk#13 (comment)
Codecov Report
@@ Coverage Diff @@
## main #19 +/- ##
============================================
+ Coverage 64.99% 65.56% +0.57%
- Complexity 157 176 +19
============================================
Files 17 21 +4
Lines 557 604 +47
Branches 97 99 +2
============================================
+ Hits 362 396 +34
- Misses 142 145 +3
- Partials 53 63 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| /** | ||
| * Returns the creation time of the last element. | ||
| */ | ||
| fun getLastCreatedAt(): TimeTicket { |
There was a problem hiding this comment.
Although it is only my personal preference, I would use property rather than functions when it always returns the same instance and has no parameters.
(same for RgaTreeList.getHead)
There was a problem hiding this comment.
If there are no problems, it would be better to unify the style. The proposed method is looking neater.
| @@ -2,14 +2,13 @@ package dev.yorkie.document.crdt | |||
|
|
|||
| import dev.yorkie.document.time.TimeTicket | |||
| import dev.yorkie.document.time.TimeTicket.Companion.InitialTimeTicket | |||
| import dev.yorkie.document.time.TimeTicket.Companion.compareTo | |||
There was a problem hiding this comment.
it looks like some of the work I've done got reverted on merge.
check 9e1f465#diff-d11a0b42e2590d7cdb00a3e25077e19cd889cc034a160dd3a99cea4c352adca4R86
There was a problem hiding this comment.
Thanks for your contribution. Please check the comments suggested by @skhugh.
| /** | ||
| * Returns the creation time of the last element. | ||
| */ | ||
| fun getLastCreatedAt(): TimeTicket { |
There was a problem hiding this comment.
If there are no problems, it would be better to unify the style. The proposed method is looking neater.
What this PR does / why we need it?
This PR is to improve test coverage based on the result from previous PR.
Any background context you want to provide?
CrdtArrayhas low test coverage since its overriding functions are not implemented yet.What are the relevant tickets?
Fixes #
Checklist