Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong dispatcher usage #184

Merged
merged 1 commit into from
May 20, 2024
Merged

Fix wrong dispatcher usage #184

merged 1 commit into from
May 20, 2024

Conversation

skhugh
Copy link
Contributor

@skhugh skhugh commented May 17, 2024 •
edited
Loading

What this PR does / why we need it?

I made a mistak on #174.
snapshotDispatcher should have been used only on applySnapshot but it was applied on the whole applyChange method.

Also added a mutex for applyChange, since dispatcher can be multi-threaded.

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@skhugh skhugh requested a review from 7hong13 May 17, 2024 10:14
@skhugh skhugh self-assigned this May 17, 2024
@skhugh skhugh merged commit a1cefb2 into main May 20, 2024
4 of 6 checks passed
@skhugh skhugh deleted the dispatcher_fix branch May 20, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7hong13 7hong13 7hong13 approved these changes

Assignees

@skhugh skhugh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skhugh @7hong13