Pass better information of operation failures #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7hong13
approved these changes
May 14, 2024
| @@ -24,7 +24,9 @@ class KanbanBoardViewModel(private val client: Client) : ViewModel() { | |||
|
|
|||
| init { | |||
| viewModelScope.launch { | |||
| if (client.activateAsync().await() && client.attachAsync(document).await()) { | |||
| if (client.activateAsync().await().isSuccess && | |||
| client.attachAsync(document).await().isFailure | |||
There was a problem hiding this comment.
I think it should be client.attachAsync(document).await().isSuccess
| @@ -129,7 +130,7 @@ public class Document( | |||
| public fun updateAsync( | |||
| message: String? = null, | |||
| updater: suspend (root: JsonObject, presence: Presence) -> Unit, | |||
| ): Deferred<Boolean> { | |||
| ): Deferred<Result<Unit>> { | |||
There was a problem hiding this comment.
typealias OperationResult can be applied here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Changes return type of public operations from Boolean to Result for better information.
This can help users to handle exceptions more precisely.
Also bumps libraries to latest versions.
Any background context you want to provide?
What are the relevant tickets?
Fixes #
Checklist