Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure every presence event is published #164

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Ensure every presence event is published #164

merged 1 commit into from
Mar 29, 2024

Conversation

7hong13
Copy link
Contributor

@7hong13 7hong13 commented Mar 29, 2024

What this PR does / why we need it?

Currently, PresenceEvents are published only when the new presence differs from the previous one. However, even if there is no change in presence, the events should still be published to the SDK users. For example, when putting JsonTree-related information into the presence, it can be interpreted differently depending on the state of the JsonTree that the user is consuming.
This PR ensures that every PresenceEvent is emitted to the Document.eventstream.

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@7hong13 7hong13 self-assigned this Mar 29, 2024
@7hong13 7hong13 added the bug 🐞 Something isn't working label Mar 29, 2024
@7hong13 7hong13 changed the title fix presence events handling Ensure every presence event is published Mar 29, 2024
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 79.42%. Comparing base (68a06c5) to head (d03b186).

Files Patch % Lines
...ie/src/main/kotlin/dev/yorkie/document/Document.kt 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
- Coverage   79.46%   79.42%   -0.05%     
==========================================
  Files          63       63              
  Lines        3877     3879       +2     
  Branches      608      608              
==========================================
  Hits         3081     3081              
- Misses        469      470       +1     
- Partials      327      328       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@7hong13 7hong13 requested a review from skhugh March 29, 2024 11:28
@7hong13 7hong13 marked this pull request as ready for review March 29, 2024 11:28
@7hong13 7hong13 merged commit 8c2e63f into main Mar 29, 2024
6 checks passed
@7hong13 7hong13 deleted the presence branch March 29, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants