Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Tree element & operation converters #116

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Conversation

skhugh
Copy link
Contributor

@skhugh skhugh commented Jul 3, 2023

What this PR does / why we need it?

Implements converters for Tree element & Tree-related operations.

Any background context you want to provide?

Will add test codes very soon.

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@skhugh skhugh self-assigned this Jul 3, 2023
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #116 (a770916) into main (b41b89d) will decrease coverage by 1.77%.
The diff coverage is 5.10%.

@@             Coverage Diff              @@
##               main     #116      +/-   ##
============================================
- Coverage     71.39%   69.63%   -1.77%     
  Complexity      670      670              
============================================
  Files            61       61              
  Lines          3454     3540      +86     
  Branches        507      525      +18     
============================================
- Hits           2466     2465       -1     
- Misses          723      805      +82     
- Partials        265      270       +5     
Impacted Files Coverage Δ
...c/main/kotlin/dev/yorkie/api/OperationConverter.kt 91.48% <0.00%> (-8.52%) ⬇️
...src/main/kotlin/dev/yorkie/api/ElementConverter.kt 57.78% <2.43%> (-20.00%) ⬇️
...c/main/kotlin/dev/yorkie/document/crdt/CrdtTree.kt 51.68% <75.00%> (-0.20%) ⬇️

@skhugh skhugh merged commit bf76d11 into main Jul 4, 2023
@skhugh skhugh deleted the tree_converters branch July 4, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants