Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x-shard-key to APIs #102

Merged
merged 8 commits into from
Jun 5, 2023
Merged

Add x-shard-key to APIs #102

merged 8 commits into from
Jun 5, 2023

Conversation

7hong13
Copy link
Contributor

@7hong13 7hong13 commented May 26, 2023

What this PR does / why we need it?

Add x-shard-key to APIs

Any background context you want to provide?

What are the relevant tickets?

Related to yorkie-team/yorkie#499

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@7hong13 7hong13 requested a review from skhugh May 26, 2023 09:23
@7hong13 7hong13 self-assigned this May 26, 2023
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #102 (82f90d5) into main (7608a45) will increase coverage by 0.15%.
The diff coverage is 90.00%.

❗ Current head 82f90d5 differs from pull request most recent head 0efd090. Consider uploading reports for the commit 0efd090 to get more accurate results

@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
+ Coverage   82.37%   82.53%   +0.15%     
==========================================
  Files          52       52              
  Lines        2474     2490      +16     
  Branches      342      344       +2     
==========================================
+ Hits         2038     2055      +17     
+ Misses        257      251       -6     
- Partials      179      184       +5     
Impacted Files Coverage Δ
yorkie/src/main/kotlin/dev/yorkie/core/Client.kt 86.30% <89.47%> (+0.05%) ⬆️
...ie/src/main/kotlin/dev/yorkie/core/Interceptors.kt 71.42% <100.00%> (+28.57%) ⬆️

... and 1 file with indirect coverage changes

@7hong13 7hong13 requested review from hackerwins and daeyounglnc May 30, 2023 05:10
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@7hong13 7hong13 merged commit 1e59516 into main Jun 5, 2023
@7hong13 7hong13 deleted the x_shard_key branch June 5, 2023 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants