Merge pull request #246 from yoonghan/develop

Fix backstops
yoonghan · Aug 18, 2024 · f04f4a2 · f04f4a2
2 parents d099d71 + 6e18240
commit f04f4a2
Show file tree

Hide file tree

Showing 22 changed files with 10 additions and 34 deletions.
diff --git a/backstop.json b/backstop.json
@@ -32,10 +32,6 @@
       "cookiePath": "backstop_data/engine_scripts/cookies.json",
       "url": "http://localhost:3000/experiments/homepage-v1",
       "delay": 500,
-      "scrollBySelector": {
-        "id": "#parallax-container",
-        "posY": 10000
-      },
       "clickSelector": "text=Write To Us",
       "postInteractionWait": 1000,
       "selectorExpansion": true,
@@ -44,17 +40,17 @@
       "requireSameDimensions": true
     },
     {
-      "label": "Homepage on Desktop/tablet can access from navigation",
-      "url": "http://localhost:3000/experiments/homepage-v1",
+      "label": "Homepage Commandbar search on table",
       "cookieDomain": "localhost",
       "cookiePath": "backstop_data/engine_scripts/cookies.json",
+      "url": "http://localhost:3000/experiments/homepage-v1",
       "delay": 500,
-      "postInteractionWait": 2000,
+      "buttonClickByName": "search",
+      "postInteractionWait": 4000,
       "selectorExpansion": true,
       "expect": 0,
-      "misMatchThreshold": 0.4,
-      "clickSelector": "nav p:text('Testing Deployment')",
-      "requireSameDimensions": true,
+      "misMatchThreshold": 0.3,
+      "requireSameDimensions": false,
       "viewports": [
         {
           "label": "tablet",
@@ -63,19 +59,6 @@
         }
       ]
     },
-    {
-      "label": "Homepage Commandbar search",
-      "cookieDomain": "localhost",
-      "cookiePath": "backstop_data/engine_scripts/cookies.json",
-      "url": "http://localhost:3000/experiments/homepage-v1",
-      "delay": 500,
-      "buttonClickByName": "search",
-      "postInteractionWait": 4000,
-      "selectorExpansion": true,
-      "expect": 0,
-      "misMatchThreshold": 0.3,
-      "requireSameDimensions": false
-    },
     {
       "label": "About Page",
       "url": "http://localhost:3000/about",

diff --git a/...maps_local_reference/walcron__Homepage_Commandbar_search_0_document_0_phone.png b/...maps_local_reference/walcron__Homepage_Commandbar_search_0_document_0_phone.png
diff --git a/...aps_local_reference/walcron__Homepage_Commandbar_search_0_document_0_tablet.png b/...aps_local_reference/walcron__Homepage_Commandbar_search_0_document_0_tablet.png
diff --git a/...aps_local_reference/walcron__Homepage_Commandbar_search_0_document_1_tablet.png b/...aps_local_reference/walcron__Homepage_Commandbar_search_0_document_1_tablet.png
diff --git a/...__Homepage_on_Desktop_tablet_can_access_from_navigation_0_document_0_tablet.png b/...__Homepage_on_Desktop_tablet_can_access_from_navigation_0_document_0_tablet.png
diff --git a/..._reference/walcron__Homepage_with_email_entered_and_sent_0_document_0_phone.png b/..._reference/walcron__Homepage_with_email_entered_and_sent_0_document_0_phone.png
diff --git a/...reference/walcron__Homepage_with_email_entered_and_sent_0_document_1_tablet.png b/...reference/walcron__Homepage_with_email_entered_and_sent_0_document_1_tablet.png
diff --git a/backstop_data/bitmaps_reference/walcron__Homepage_Commandbar_search_0__0_phone.png b/backstop_data/bitmaps_reference/walcron__Homepage_Commandbar_search_0__0_phone.png
diff --git a/...ta/bitmaps_reference/walcron__Homepage_Commandbar_search_0_document_0_phone.png b/...ta/bitmaps_reference/walcron__Homepage_Commandbar_search_0_document_0_phone.png
diff --git a/...a/bitmaps_reference/walcron__Homepage_Commandbar_search_0_document_1_tablet.png b/...a/bitmaps_reference/walcron__Homepage_Commandbar_search_0_document_1_tablet.png
diff --git a/..._reference/walcron__Homepage_Commandbar_search_on_table_0_document_0_tablet.png b/..._reference/walcron__Homepage_Commandbar_search_on_table_0_document_0_tablet.png
diff --git a/...__Homepage_on_Desktop_tablet_can_access_from_navigation_0_document_0_tablet.png b/...__Homepage_on_Desktop_tablet_can_access_from_navigation_0_document_0_tablet.png
diff --git a/...reference/walcron__Homepage_with_email_entered_and_sent_0_document_1_tablet.png b/...reference/walcron__Homepage_with_email_entered_and_sent_0_document_1_tablet.png
diff --git a/...ata/bitmaps_reference/walcron__Storybook_-_Confirmation__0_document_0_phone.png b/...ata/bitmaps_reference/walcron__Storybook_-_Confirmation__0_document_0_phone.png
diff --git a/...ta/bitmaps_reference/walcron__Storybook_-_Confirmation__0_document_1_tablet.png b/...ta/bitmaps_reference/walcron__Storybook_-_Confirmation__0_document_1_tablet.png
diff --git a/backstop_data/bitmaps_reference/walcron__Storybook_-_Dialog_0_document_0_phone.png b/backstop_data/bitmaps_reference/walcron__Storybook_-_Dialog_0_document_0_phone.png
diff --git a/...stop_data/bitmaps_reference/walcron__Storybook_-_Dialog_0_document_1_tablet.png b/...stop_data/bitmaps_reference/walcron__Storybook_-_Dialog_0_document_1_tablet.png
diff --git a/backstop_data/bitmaps_reference/walcron__Storybook_0_document_0_phone.png b/backstop_data/bitmaps_reference/walcron__Storybook_0_document_0_phone.png
diff --git a/backstop_data/bitmaps_reference/walcron__Storybook_0_document_1_tablet.png b/backstop_data/bitmaps_reference/walcron__Storybook_0_document_1_tablet.png
diff --git a/backstopjs.approve b/backstopjs.approve
@@ -1 +1 @@
-569
+575
diff --git a/src/app/experiments/storybook/config/PopupKeyboard.tsx b/src/app/experiments/storybook/config/PopupKeyboard.tsx
@@ -4,12 +4,10 @@ import PopupKeyboard from "@/components/PopupKeyboard"
 
 const emptyFn = () => {}
 
-const ArrowKeyboard = (
+export const ArrowKeyboard = () => (
   <PopupKeyboard
     keyboardType="Arrows"
     onClickCallback={emptyFn}
     buttonText={"Show Me"}
   />
 )
-
-export default ArrowKeyboard
diff --git a/src/app/experiments/storybook/config/componentList.tsx b/src/app/experiments/storybook/config/componentList.tsx
@@ -1,9 +1,8 @@
-import MegaMenu from "@/components/MegaMenu"
 import dynamic from "next/dynamic"
 import ButtonsBar from "./ButtonsBar"
 import Cards from "./Cards"
 import Tables from "./Tables"
-import PopupKeyboard from "./PopupKeyboard"
+import { ArrowKeyboard } from "./PopupKeyboard"
 import Canvases from "./Canvases"
 import ScrollableListDemo from "./ScrollableList"
 import { OrderedFigure, ReversedFigure } from "./Figure"
@@ -21,10 +20,6 @@ export const storyBookList = [
     title: "Dialogs",
     component: <NoSSRDialog />,
   },
-  {
-    title: "Menu",
-    component: <MegaMenu />,
-  },
   {
     title: "Cards",
     component: Cards,
@@ -43,7 +38,7 @@ export const storyBookList = [
   },
   {
     title: "Keyboard",
-    component: PopupKeyboard,
+    component: <ArrowKeyboard />,
   },
   {
     title: "Canvases",