Merge pull request #268 from yoonghan/metric

Send ga metric as int
yoonghan · Aug 29, 2024 · 02505df · 02505df
2 parents 490fb8d + 891cf46
commit 02505df
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/__tests__/mocks/walcron-microfrontend-shared.ts b/src/__tests__/mocks/walcron-microfrontend-shared.ts
@@ -4,7 +4,7 @@ jest.mock("@yoonghan/walcron-microfrontend-shared", () => {
     reportWebVitals: (callback: any) => {
       callback({
         name: "CLS",
-        delta: 1,
+        delta: 1.1,
         id: "test",
         value: 2,
       })

diff --git a/src/components/GoogleAnalytic/GoogleAnalytic.jest.test.tsx b/src/components/GoogleAnalytic/GoogleAnalytic.jest.test.tsx
@@ -19,7 +19,7 @@ describe("Google Analytic", () => {
       metric_delta: 1,
       metric_id: "test",
       metric_value: 2,
-      value: 1,
+      value: 1.1,
     })
 
     rerender(<GoogleAnalytic ga4Id={gaValue} />)

diff --git a/src/components/GoogleAnalytic/index.tsx b/src/components/GoogleAnalytic/index.tsx
@@ -20,10 +20,10 @@ export function GoogleAnalytic({ ga4Id }: Props) {
     */
     reportWebVitals(({ name, delta, id, value }) => {
       ReactGA.event(name, {
-        value: Math.floor(delta),
+        value: delta,
         metric_id: id,
         metric_value: value,
-        metric_delta: delta,
+        metric_delta: Math.floor(delta),
       })
     })
   }, [ga4Id])