Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use host (handler) logger instead of std log. #86

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use host (handler) logger instead of std log. #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions host.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ func NewHandler(sessionHandler SessionHandler, clientFactory ClientFactory) Hand
return &defaultHandler{
sessionHandler: sessionHandler,
newClient: clientFactory,
logger: log.Default(),
}
}

Expand All @@ -42,7 +43,7 @@ func (h *defaultHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
c, err := h.newClient()
if err != nil {
http.Error(w, "failed to connect to FastCGI application", http.StatusBadGateway)
log.Printf("gofast: unable to connect to FastCGI application. %s",
h.logger.Printf("gofast: unable to connect to FastCGI application. %s",
err.Error())
return
}
Expand All @@ -56,7 +57,7 @@ func (h *defaultHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
// signal to close the client
// or the pool to return the client
if err = c.Close(); err != nil {
log.Printf("gofast: error closing client: %s",
h.logger.Printf("gofast: error closing client: %s",
err.Error())
}
}()
Expand All @@ -65,17 +66,17 @@ func (h *defaultHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
resp, err := h.sessionHandler(c, NewRequest(r))
if err != nil {
http.Error(w, "failed to process request", http.StatusInternalServerError)
log.Printf("gofast: unable to process request %s",
h.logger.Printf("gofast: unable to process request %s",
err.Error())
return
}
errBuffer := new(bytes.Buffer)
if err = resp.WriteTo(w, errBuffer); err != nil {
log.Printf("gofast: problem writing error buffer to response - %s", err)
h.logger.Printf("gofast: problem writing error buffer to response - %s", err)
}

if errBuffer.Len() > 0 {
log.Printf("gofast: error stream from application process %s",
h.logger.Printf("gofast: error stream from application process %s",
errBuffer.String())
}
}