Skip failing test on Linux until upstream fix #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosgriselli
commented
Oct 24, 2024
| @@ -9,7 +9,11 @@ import TestSupport | |||
|
|
|||
| class SourceGeneratorTests: XCTestCase { | |||
|
|
|||
| func testSourceGenerator() { | |||
| func testSourceGenerator() throws { | |||
| #if os(Linux) && swift(<6.0.2) | |||
There was a problem hiding this comment.
Swift version is constrained to ensure it tries to run again when a new release is out.
|
@yonaskolb let me know if you don't want to be skipping these. The alternative here is to run CI from a Linux container that has an older Swift version without this issue but in practice as of now the tool fails for people running on Swift 6+ on Linux. |
|
Great resolution @marcosgriselli, thank you |
yonaskolb
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linux CI job started failing after ubuntu-latest was updated
from: actions/runner-images@ubuntu22/20240908.1/images/ubuntu/Ubuntu2204-Readme.md
to: actions/runner-images@ubuntu22/20241006.1/images/ubuntu/Ubuntu2204-Readme.md
The error message was "The openStep format is unsupported on this platform" which comes from the new swift-foundation implementation
That functionality has now been back-ported to the state it was on Swift 5.10 on this PR swiftlang/swift-foundation#1002 so Linux test should pass whenever
ubunutu-latestincludes a swift version with the fix.Skipping is not the most elegant solution but it's better than a 100% red CI since the tool will already fail for Swift 6+ in Linux and there's no way to workaround the problem in foundation.