Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom URL (Json) not working on Firefox #173

Closed
Latrolage opened this issue Jun 10, 2023 · 9 comments · Fixed by #209
Closed

Custom URL (Json) not working on Firefox #173

Latrolage opened this issue Jun 10, 2023 · 9 comments · Fixed by #209
Labels
kind/bug The issue or PR is regarding a bug

Comments

@Latrolage
Copy link

Latrolage commented Jun 10, 2023

Description
(Describe what the issue is, if it is reproducible, and if possible, how to reproduce it.)
Using firefox, I tried to use https://github.com/themoeway/local-audio-yomichan with yomitan but it would just act as if there was no audio sent back from the addon. (and in console, there was no http request like the other audio sources)

When I tried it with Version 113.0.5672.126 (Official Build, ungoogled-chromium) it worked properly.
Edit: it also works properly on the original yomichan (22.10.23.0)

Browser version
Firefox 114.0.1 (64-bit)

Yomichan version

Version
23.4.7.0

Exported settings file
It doesn't work on a clean firefox install with clean yomitan settings (but with jmdict imported)

@Latrolage Latrolage added the kind/bug The issue or PR is regarding a bug label Jun 10, 2023
@Aquafina-water-bottle
Copy link

Hey @Latrolage,

Can you try navigating through the following:

Click on the Yomitan icon -> Information (question mark circle) -> Permissions (bottom of the page) -> Configure allowed origins… -> Allow access to all URLs (switch on)

image

Likely related to #127

@Latrolage
Copy link
Author

I checked just now but the option was already enabled.

@Aquafina-water-bottle
Copy link

Can you send your settings file to make 100% sure nothing about it is off?

@Latrolage
Copy link
Author

Latrolage commented Jun 10, 2023

yomitan-settings-2023-06-10-11-31-53.txt

Also, custom URL (json) works normally on the original yomichan

@Aquafina-water-bottle
Copy link

Settings file looks good, thank you!

Just to make sure:

a) Under about:addons (url) -> Extensions -> Yomitan -> Permissions, Access your data for all websites is turned on, like the image below:
image

b) If you open Anki in the console, are there any messages from the local audio server printed to the console when you try playing audio?

c) What operating system are you on?

Unfortunately, I'm not all too sure what's going on here :(

@Latrolage
Copy link
Author

Latrolage commented Jun 11, 2023

a) Yes that's turned on
b) No, nothing at all, and in browser console for yomichan, it doesn't send a http request either.
On the other hand when I do it on chromium, it prints [] when there is no audio or something, and it prints: [{'name': 'JPod101', 'url': 'http://localhost:5050/jpod/よむ - 読む.mp3'}, {'name': 'JPod101 Alt', 'url': 'http://localhost:5050/jpod_alternate/よむ - 読む.mp3'}, {'name': 'NHK16 ヨ\ム [1]', 'url': 'http://localhost:5050/nhk16/audio/20180221161451.aac'}, {'name': 'Forvo (strawberrybrown)', 'url': 'http://localhost:5050/forvo/strawberrybrown/読む.mp3'}] when there is a match.
The original yomichan also does the same.
c) Arch linux

I'm assuming this is just a me thing then if no one else can reproduce. I'll test on my laptop to check if it's just 1 of my computers having this problem

@Latrolage
Copy link
Author

Latrolage commented Jun 11, 2023

Ummm, as I was messing around, with yomitan and yomichan, it just started working again. I'm not sure what I changed tbh, I'm still on yomitan 23.4.7.0 but it's working now.

@Latrolage Latrolage closed this as not planned Won't fix, can't repro, duplicate, stale Jun 11, 2023
@Latrolage
Copy link
Author

Latrolage commented Jun 24, 2023

Seems inconsistent. It's not working properly again, the original yomichan's one works consistently though.

@Latrolage Latrolage reopened this Jun 24, 2023
@praschke
Copy link
Collaborator

Ummm, as I was messing around, with yomitan and yomichan, it just started working again. I'm not sure what I changed tbh, I'm still on yomitan 23.4.7.0 but it's working now.

It works whenever I've freshly installed the extension, and stops working after Firefox restarts. When it breaks, calling declarativeNetRequest.updateDynamicRules returns with an unexpected error. This is a Firefox bug.

praschke added a commit to praschke/yomitan that referenced this issue Aug 16, 2023
`declarativeNetRequest.updateDynamicRules()` returns with an
unexpected error in Firefox, but only after the browser has been
restarted. On a fresh install of Yomitan it works, causing bug
flakiness. `declarativeNetRequest` can be disabled in the manifest as
a workaround.
praschke added a commit to praschke/yomitan that referenced this issue Aug 16, 2023
`declarativeNetRequest.updateDynamicRules()` returns with an
unexpected error in Firefox, but only after the browser has been
restarted. On a fresh install of Yomitan it works, causing bug
flakiness. `declarativeNetRequest` can be disabled in the manifest as
a workaround.
praschke added a commit to praschke/yomitan that referenced this issue Aug 16, 2023
`declarativeNetRequest.updateDynamicRules()` returns with an
unexpected error in Firefox, but only after the browser has been
restarted. On a fresh install of Yomitan it works, causing bug
flakiness. `declarativeNetRequest` can be disabled in the manifest as
a workaround.
@praschke praschke mentioned this issue Aug 16, 2023
praschke added a commit to praschke/yomitan that referenced this issue Aug 17, 2023
`declarativeNetRequest.updateDynamicRules()` returns with an
unexpected error in Firefox, but only after the browser has been
restarted. On a fresh install of Yomitan it works, causing bug
flakiness. `declarativeNetRequest` can be disabled in the manifest as
a workaround.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug The issue or PR is regarding a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants