REPEATED_FIELD_NAMES_PLURALIZED accounts for 'info' as uncountable names

yoheimuta · Jan 29, 2025 · 18d2bb3 · 18d2bb3
1 parent 6a089f1
commit 18d2bb3
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/_example/proto/issue_447/info.proto b/_example/proto/issue_447/info.proto
@@ -0,0 +1,5 @@
+syntax = "proto3";
+
+message Xyz {
+  repeated AdditionalInfo additional_info = 1;
+}
diff --git a/linter/strs/pluralize.go b/linter/strs/pluralize.go
@@ -16,6 +16,7 @@ func NewPluralizeClient() *PluralizeClient {
 	}
 	c.AddPluralRule("(?i)uri$", "uris")
 	c.AddSingularRule("(?i)uris$", "uri")
+	c.AddUncountableRule("(?i)info$")
 	return c
 }
 

diff --git a/linter/strs/pluralize_test.go b/linter/strs/pluralize_test.go
@@ -25,6 +25,8 @@ func TestPluralizeClient_ToPlural(t *testing.T) {
 		{"special case #312: appends s to module_uri", "module_uri", "module_uris"},
 		{"special case #312: not change uris", "uris", "uris"},
 		{"special case #312: not change module_uris", "module_uris", "module_uris"},
+		{"case #447: PluralizeUncountableWord", "info", "info"},
+		{"case #447: PluralizeUncountableWord2", "additional_info", "additional_info"},
 	}
 	for _, test := range tests {
 		test := test