Code cleaning

demo/movegeneration.js

@@ -83,7 +83,6 @@ function run(fen, minDepth, maxDepth, verbose) {
 }
 
 
-
 // -----------------------------------------------------------------------------
 // Command line parsing
 // -----------------------------------------------------------------------------

demo/pgnparsing.js

@@ -116,13 +116,12 @@ function run(paths, pathAlignment) {
             'Loading: ' + alignRight(duration2, 6) + ' ms');
     }
 
-    for (const [path, error] of errors.entries()) {
+    for (const [ path, error ] of errors.entries()) {
         displayInvalidPGNError(path, error);
     }
 }
 
 
-
 // -----------------------------------------------------------------------------
 // Command line parsing
 // -----------------------------------------------------------------------------

src/base_types.ts

@@ -103,15 +103,15 @@ export type Coordinates = {
      * - ...
      * - `7` for file H
      */
-    file: number;
+    file: number,
 
     /**
      * - `0` for rank 1
      * - `1` for rank 2
      * - ...
      * - `7` for rank 8
      */
-    rank: number;
+    rank: number,
 };
 
 

src/database.ts

@@ -82,7 +82,7 @@ export abstract class Database {
         return {
             [Symbol.iterator]() {
                 return new GameIteratorImpl(gameCount, gameLoader);
-            }
+            },
         };
     }
 

src/date_value.ts

@@ -265,7 +265,7 @@ function computeType(year: number, month?: number, day?: number): false | 'y' |
         return isValidYear(year) && isValidMonth(month) ? 'ym' : false;
     }
     else {
-        return isValidYear(year) ? 'y': false;
+        return isValidYear(year) ? 'y' : false;
     }
 }
 

src/game.ts

@@ -981,7 +981,7 @@ function formatPlayer(key: string, playerName: string | undefined, playerElo: nu
         result += ` (${playerElo})`;
     }
     else if (playerTitle !== undefined) {
-        result +=  ` (${trimCollapseAndMarkEmpty(playerTitle)})`;
+        result += ` (${trimCollapseAndMarkEmpty(playerTitle)})`;
     }
     return result;
 }

src/game_pojo.ts

@@ -29,9 +29,9 @@ import { GameResult, GameVariant } from './base_types';
  * Represent the player-related headers in a {@link GamePOJO}.
  */
 export type PlayerPOJO = {
-    name?: string;
-    elo?: number;
-    title?: string;
+    name?: string,
+    elo?: number,
+    title?: string,
 };
 
 
@@ -42,53 +42,53 @@ export type PlayerPOJO = {
 export type GamePOJO = {
 
     // Headers
-    white?: PlayerPOJO;
-    black?: PlayerPOJO;
-    event?: string;
-    round?: number;
-    subRound?: number;
-    subSubRound?: number;
-    date?: string;
-    site?: string;
-    annotator?: string;
-    eco?: string;
-    opening?: string;
-    openingVariation?: string;
-    openingSubVariation?: string;
-    termination?: string;
-    result?: GameResult;
+    white?: PlayerPOJO,
+    black?: PlayerPOJO,
+    event?: string,
+    round?: number,
+    subRound?: number,
+    subSubRound?: number,
+    date?: string,
+    site?: string,
+    annotator?: string,
+    eco?: string,
+    opening?: string,
+    openingVariation?: string,
+    openingSubVariation?: string,
+    termination?: string,
+    result?: GameResult,
 
     // Moves
-    variant?: GameVariant;
-    initialPosition?: string;
-    mainVariation?: VariationPOJO;
+    variant?: GameVariant,
+    initialPosition?: string,
+    mainVariation?: VariationPOJO,
 };
 
 
 /**
  * Represent a {@link AbstractNode} in a {@link GamePOJO}.
  */
 export type AbstractNodePOJO = {
-    comment?: string;
-    isLongComment?: boolean;
-    nags?: number[];
-    tags?: Record<string, string>;
+    comment?: string,
+    isLongComment?: boolean,
+    nags?: number[],
+    tags?: Record<string, string>,
 };
 
 
 /**
  * Represent a {@link Node} in a {@link GamePOJO}.
  */
 export type NodePOJO = string | AbstractNodePOJO & {
-    notation: string;
-    variations?: VariationPOJO[];
+    notation: string,
+    variations?: VariationPOJO[],
 };
 
 
 /**
  * Represent a {@link Variation} in a {@link GamePOJO}.
  */
 export type VariationPOJO = NodePOJO[] | AbstractNodePOJO & {
-    nodes: NodePOJO[];
-    isLongVariation?: boolean;
+    nodes: NodePOJO[],
+    isLongVariation?: boolean,
 };

src/helper.ts

@@ -201,17 +201,18 @@ export function variantWithCanonicalStartPosition(variant: GameVariant): boolean
 
 const NAG_SYMBOLS = new Map<number, string>();
 
-NAG_SYMBOLS.set(  1, '!',           ); // good move
-NAG_SYMBOLS.set(  2, '?',           ); // bad move
-NAG_SYMBOLS.set(  3, '!!',          ); // very good move
-NAG_SYMBOLS.set(  4, '??',          ); // very bad move
-NAG_SYMBOLS.set(  5, '!?',          ); // interesting move
-NAG_SYMBOLS.set(  6, '?!',          ); // questionable move
+/* eslint-disable @stylistic/no-multi-spaces, @stylistic/space-in-parens */
+NAG_SYMBOLS.set(  1, '!'            ); // good move
+NAG_SYMBOLS.set(  2, '?'            ); // bad move
+NAG_SYMBOLS.set(  3, '!!'           ); // very good move
+NAG_SYMBOLS.set(  4, '??'           ); // very bad move
+NAG_SYMBOLS.set(  5, '!?'           ); // interesting move
+NAG_SYMBOLS.set(  6, '?!'           ); // questionable move
 NAG_SYMBOLS.set(  7, '\u25a1'       ); // Only move
 NAG_SYMBOLS.set(  8, '\u25a1'       ); // Only move (ChessBase)
 NAG_SYMBOLS.set(  9, '\u2612'       ); // Worst move (Chess.com)
-NAG_SYMBOLS.set( 10, '=',           ); // equal position
-NAG_SYMBOLS.set( 11, '=',           ); // equal position (ChessBase)
+NAG_SYMBOLS.set( 10, '='            ); // equal position
+NAG_SYMBOLS.set( 11, '='            ); // equal position (ChessBase)
 NAG_SYMBOLS.set( 13, '\u221e'       ); // unclear position
 NAG_SYMBOLS.set( 14, '\u2a72'       ); // White has a slight advantage
 NAG_SYMBOLS.set( 15, '\u2a71'       ); // Black has a slight advantage
@@ -232,8 +233,9 @@ NAG_SYMBOLS.set(140, '\u2206'       ); // With idea...
 NAG_SYMBOLS.set(141, '\u2207'       ); // Aimed against...
 NAG_SYMBOLS.set(142, '\u2313'       ); // Better is...
 NAG_SYMBOLS.set(143, '\u2264'       ); // Worse is...
-NAG_SYMBOLS.set(145, 'RR',          ); // Editorial comment
-NAG_SYMBOLS.set(146, 'N',           ); // Novelty
+NAG_SYMBOLS.set(145, 'RR'           ); // Editorial comment
+NAG_SYMBOLS.set(146, 'N'            ); // Novelty
+/* eslint-enable */
 
 
 /**

src/i18n.ts

@@ -27,7 +27,7 @@
  */
 export namespace i18n {
 
-/* eslint-disable prefer-const */
+/* eslint-disable prefer-const, @stylistic/indent, @stylistic/no-multi-spaces */
 // WARNING: all those constants must be declared with "let" to allow them to be re-defined if necessary by consumer codes.
 
 // FEN parsing error messages

src/position.ts

@@ -52,7 +52,6 @@ export class Position {
     private _impl: PositionImpl;
 
 
-
     // -------------------------------------------------------------------------
     // Constructor & reset/clear
     // -------------------------------------------------------------------------
@@ -267,7 +266,6 @@ export class Position {
     }
 
 
-
     // -------------------------------------------------------------------------
     // FEN & ASCII conversion
     // -------------------------------------------------------------------------
@@ -367,7 +365,6 @@ export class Position {
     }
 
 
-
     // -------------------------------------------------------------------------
     // Accessors
     // -------------------------------------------------------------------------
@@ -579,7 +576,6 @@ export class Position {
     }
 
 
-
     // -------------------------------------------------------------------------
     // Legality
     // -------------------------------------------------------------------------
@@ -621,7 +617,6 @@ export class Position {
     }
 
 
-
     // -------------------------------------------------------------------------
     // Move generation
     // -------------------------------------------------------------------------
@@ -841,7 +836,6 @@ export class Position {
     }
 
 
-
     // -------------------------------------------------------------------------
     // Algebraic notation
     // -------------------------------------------------------------------------
@@ -914,7 +908,6 @@ export class Position {
     }
 
 
-
     // -------------------------------------------------------------------------
     // UCI
     // -------------------------------------------------------------------------
@@ -971,17 +964,17 @@ export class Position {
  * @see {@link Position.isMoveLegal}
  */
 export type RegularMoveFactory = {
-    status: 'regular';
-    (): MoveDescriptor;
+    status: 'regular',
+    (): MoveDescriptor,
 };
 
 
 /**
  * @see {@link Position.isMoveLegal}
  */
 export type PromotionMoveFactory = {
-    status: 'promotion';
-    (promotion: Piece): MoveDescriptor;
+    status: 'promotion',
+    (promotion: Piece): MoveDescriptor,
 };
 
 

src/private_game/node_variation_impl.ts

@@ -654,7 +654,7 @@ function getTagKeys(data: AbstractNodeData) {
  */
 function filterTags(data: AbstractNodeData, filter: (tagKey: string, tagValue: string) => boolean) {
     const result = new Map<string, string>();
-    for (const [tagKey, tagValue] of data.tags.entries()) {
+    for (const [ tagKey, tagValue ] of data.tags.entries()) {
         if (filter(tagKey, tagValue)) {
             result.set(tagKey, tagValue);
         }
@@ -668,7 +668,7 @@ function filterTags(data: AbstractNodeData, filter: (tagKey: string, tagValue: s
  */
 function getTagRecords(data: AbstractNodeData) {
     const result: Record<string, string> = {};
-    for (const [tagKey, tagValue] of data.tags.entries()) {
+    for (const [ tagKey, tagValue ] of data.tags.entries()) {
         result[tagKey] = tagValue;
     }
     return result;

src/private_pgn/pgn_read_impl.ts

@@ -101,12 +101,12 @@ function parseVariant(value: string): GameVariant | undefined {
 
 
 interface InitialPositionFactory {
-    fen?: string;
-    fenTokenCharacterIndex?: number;
-    fenTokenLineIndex?: number;
-    variant?: GameVariant;
-    variantTokenCharacterIndex?: number;
-    variantTokenLineIndex?: number;
+    fen?: string,
+    fenTokenCharacterIndex?: number,
+    fenTokenLineIndex?: number,
+    variant?: GameVariant,
+    variantTokenCharacterIndex?: number,
+    variantTokenLineIndex?: number,
 }
 
 
@@ -202,7 +202,7 @@ function doParseGame(stream: TokenStream) {
     const game = new Game(); // the result
     let endOfGameEncountered = false;
     let atLeastOneTokenFound = false;
-    let node: Node | Variation | null = null;  // current node (or variation) to which the next move should be appended
+    let node: Node | Variation | null = null; // current node (or variation) to which the next move should be appended
     const nodeStack: (Node | Variation)[] = []; // when starting a variation, its parent node (btw., always a "true" node, not a variation) is stacked here
     const initialPositionFactory: InitialPositionFactory = {};
 

src/private_pgn/pgn_write_impl.ts

@@ -103,7 +103,7 @@ function writeAnnotations(node: AbstractNode, skipLineAfterCommentIfLong: boolea
 
     // Prepare tags
     const tags = node.tags();
-    const tagValues: Map<string, string> = new Map();
+    const tagValues = new Map<string, string>();
     let nonEmptyTagFound = false;
     for (const tagKey of tags) {
         const tagValue = trimAndCollapseSpaces(node.tag(tagKey)!.replace(/[[\]]/g, '')); // Square-brackets are erased in tag values in PGN.
@@ -211,7 +211,7 @@ export interface PGNWriteOptions {
     /**
      * If `true`, a PGN tag `[PlyCount "..."]` corresponding to the number of half-moves is added to each game in the generated PGN string. `false` by default.
      */
-    withPlyCount?: boolean;
+    withPlyCount?: boolean,
 }