Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap CarelinkClient token parameters in validate_input #77

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

arandall
Copy link
Contributor

When trying to test this component I realised that the CarelinkClient parameters were not consistent with the class __init__ function resulting in the refresh and access tokens being swapped and auth failing.

This fixes #76 by swapping the parameters allowing the UI fields to map correctly.

When trying to test this component I realised that the `CarelinkClient`
parameters were not consistent with the class `__init__` function
resulting in the refresh and access tokens being swapped and auth
failing.

This fixes yo-han#76 by swapping the parameters allowing the UI fields to map
correctly.
@arandall arandall requested a review from yo-han as a code owner March 24, 2024 07:24
Copy link
Owner

@yo-han yo-han left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find, thanks!

@yo-han yo-han merged commit 1cad189 into yo-han:develop Mar 24, 2024
2 checks passed
@arandall arandall deleted the fix-ui-field-mapping branch April 12, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to configure using UI - cl_token and cl_refresh_token fields mapped incorrectly
2 participants