Publish: Workfile collector #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigRoy
reviewed
Apr 9, 2024
| self.log.error("No current filepath detected. " | ||
| "Make sure to save your OpenRV session") | ||
| current_file = "" | ||
| current_file = host.get_current_workfile() or "" | ||
|
|
||
| folder, file = os.path.split(current_file) | ||
| filename, ext = os.path.splitext(file) | ||
|
|
||
| instance.context.data["currentFile"] = current_file |
There was a problem hiding this comment.
In many hosts the currentFile is used for all instances in the context, not just the workfile product type. But applying this here only when there is a workfile instance that context.data["currentFile"] is not set when the workfile instance is disabled during publishing. (Because it is an InstancePlugin that runs over families = ["workfile"]. The question then arises, whether this should actually run in a separate ContextPlugin instead of here. That also makes it way less important to run at the earlier order maybe?
There was a problem hiding this comment.
I can't tell. I just noticed this weird logic and made a PR, that at least validate that we don't try to publish invalid representation.
kalisp
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed order of workfile collecto to happen much earlier. Workfile representation is not created if there is no current file which would create invalid representation, added validator which checks if workfile is set.