Convert addon for new ayon core #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigRoy
reviewed
Apr 9, 2024
Comment on lines
19
to
+20
| if frame_start is None or frame_end is None: | ||
| log.warning("No edit information found for {}".format(asset_name)) | ||
| log.warning("No edit information found for {}".format(folder_path)) |
There was a problem hiding this comment.
As far as I know folder entities in AYON always have attrib.frameStart and attrib.frameEnd. When it does not that would be considered a bug in the backend? Right? If that's ensured to exist always on a folder then maybe this is None check can be removed?
There was a problem hiding this comment.
Will do with task entity PR :)
BigRoy
reviewed
Apr 9, 2024
Comment on lines
+12
to
+14
| folder_entity = get_current_folder_entity(fields={"path", "attrib"}) | ||
| folder_path = folder_entity["path"] | ||
| folder_attribs = folder_entity["attrib"] |
There was a problem hiding this comment.
Since AYON core refactoring many other DCCs swapped this out with using the attributes from the Task Entity instead. Should this as well? get_current_task_entity?
There was a problem hiding this comment.
I wanted, but then I was like: That should be different PR, it can be in changelog.
BigRoy
reviewed
Apr 9, 2024
BigRoy
reviewed
Apr 9, 2024
kalisp
approved these changes
Apr 10, 2024
kalisp
pushed a commit
that referenced
this pull request
Apr 19, 2024
…working into bpc/main Reviewed-on: https://git.bepic.berlin/ayon/ayon-openrv/pulls/2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes related to 0.3.0 release of ayon core. All changes happened in client code.
Additional information
Use
ayon_coreoveropenpype.Testing notes