Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime dependencies are based on dependency packages #78

Merged
merged 4 commits into from
Jan 4, 2024

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Dec 28, 2023

Changelog Description

Remove dependency packages that should be defined by ayon-core/openpype addon and use runtime dependencies from dependency package.

Additional info

This PR will be combination of PRs in multiple repositories (OpenPype, ayon-dependencies-tool, ayon-launcher).

Testing notes:

  1. Create ayon-launcher installer with this PR
  2. Upload installer to server
  3. Upload OpenPype addon with required change
  4. Create a bundle with the installer and OpenPype addon
  5. Create dependency package for the bundle and use it in the bundle
  6. Run ayon-launcher with the bundle
  7. All should be working

@BigRoy
Copy link
Contributor

BigRoy commented Dec 28, 2023

Remove dependency packages that should be defined by ayon-core/openpype addon and use runtime dependencies from dependency package.

Could you elaborate why this must be the case?

The way I understand it: These are not dependencies to the launcher, but are dependencies to OpenPype addon.

However, what makes it a runtime dependency? At what runtime? For the launcher? For a host application? When/where do these dependencies get injected to what environment? Does this PR solve e.g. the Houdini 20 issues for PIL?

@iLLiCiTiT
Copy link
Member Author

iLLiCiTiT commented Dec 28, 2023

Could you elaborate why this must be the case?

In sum, runtime dependencies are available only in ayon-launcher process, and are not added to PYTHONPATH. The removed ones are not required by ayon-launcher to work, but are required by openpype addon.

Does this PR solve e.g. the ynput/OpenPype#5921 (comment)?

It should (but Pillow was already in runtime dependencies for AYON).

Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runtime dependencies (PIL, OTIO) are moved to dependency package and not launcher.

@kalisp kalisp assigned iLLiCiTiT and unassigned kalisp Jan 4, 2024
@iLLiCiTiT iLLiCiTiT merged commit 19eaa96 into develop Jan 4, 2024
@iLLiCiTiT iLLiCiTiT deleted the enhancement/remove-third-party-deps branch January 4, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants