Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Install directory fill fix #29

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Aug 3, 2023

Changelog Description

Path where application is installed should be filled correctly. Fix /INSTALLDIR=... logic.

Additional info

The path always ended in local app data because it was the last option in code block (some Pascal condition logic).

Testing notes:

  1. Make installer
  2. Run installer and choose to install for ALL USERS
    • Path to Program files should be prefilled
  3. Run installer and choose to install only locally
    • Path to Local app data should be prefilled
  4. Run installer through command line and add custom install root <installer path> /INSTALLROOt="C:\my custom\path"
    • Path to C:\my custom\path\AYON <version> should be prefilled

@iLLiCiTiT iLLiCiTiT merged commit 87699c6 into develop Aug 3, 2023
@iLLiCiTiT iLLiCiTiT deleted the bugfix/install-dir-fix branch August 3, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant