Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shim: On macOs can be used as shim #152

Merged
merged 5 commits into from
Aug 19, 2024

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Aug 19, 2024

Changelog Description

Shim in macOs build can be actually used.

Additional info

Changed how shim works on macOs. There are 2 executables on macOs. One is ayon which can be used as shim (if needed), second is ayon_macos. The second is used as main executable of AYON.app. When user opens AYON.app, or starts ayon-launcher:// scheme, it uses ayon_macos, which opens new process of ayon and closes immediately. And ayon executable start AYON launcher and waits to finish.

Testing notes:

  1. Webactions still work on macOs.

Resolves #150

@iLLiCiTiT iLLiCiTiT requested a review from 64qam August 19, 2024 09:25
@iLLiCiTiT iLLiCiTiT mentioned this pull request Aug 19, 2024
@iLLiCiTiT iLLiCiTiT changed the title Shim: macOs shim can be used as shim Shim: ON macOs can be used as shim Aug 19, 2024
@iLLiCiTiT iLLiCiTiT changed the title Shim: ON macOs can be used as shim Shim: On macOs can be used as shim Aug 19, 2024
Copy link
Member

@64qam 64qam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working. However, the pop up message shows this when a webaction is activated.
image

@iLLiCiTiT
Copy link
Member Author

iLLiCiTiT commented Aug 19, 2024

Does not happen to me with newest AYON frontend. I guess it is connected to this commit ynput/ayon-frontend@1dc1f72

EDITE: I just realized it could be because I'm using too old frontend, revalidating and will report to Luke if it is issue...

@iLLiCiTiT iLLiCiTiT merged commit 9a23800 into develop Aug 19, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/macos-shim-enhancement branch August 19, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MacOs shim can be used as unique path
2 participants