Chore: Scripts don't rely on POETRY_HOME env variable #142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Manage.ps1 and make.sh scripts do not rely on
POETRY_HOME
environment variable but always use relative path to repository.Additional info
The scripts did rely on the environment variable value and did set the variable only if was not set already. If there is global env variable set for user, or user have terminal which has set the env variable from different script it uses wrong path which leads to confusion and potentially broken environment.
The environment variable is set only when create-env is called to define target path, which is not possible with arguments.
Testing notes:
./.poetry/
with it's content (and./.venv/
).POETRY_HOME
to some random directory../manage.ps1 create-env
on windows or./make.sh create-env
on linux/macOsPOETRY_HOME
../manage.ps1 run
on windows or./make.sh run
on linux/macOs.POETRY_HOME
is not set.