Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: Delete launcher and dependency files #1016

Merged

Conversation

flynput
Copy link
Contributor

@flynput flynput commented Feb 12, 2025

  • Delete launcher and dependency files.
  • Table sorting
  • Table multi-selection
Screen.Recording.2025-02-17.at.08.09.07.mov

@flynput flynput requested a review from Innders February 12, 2025 12:00
@flynput flynput self-assigned this Feb 12, 2025
@flynput flynput linked an issue Feb 12, 2025 that may be closed by this pull request
@Innders
Copy link
Member

Innders commented Feb 12, 2025

  • Upload lots of installers and dep packages to mimic production
  • Scrolling issues.
  • Table padding and styling.
  • Also open with default as upload.
  • Argument ARC file upload for extra buttons.
  • Do not show for addons file upload. Dep packages upload should show dep packages to delete.
  • Use tanstack table
  • Adding sorting for the columns
  • Multi-selection
  • Confirmation dialog when deleting.
  • Sorting versions using semver.
  • Add sorting arrows for when not sorting (sort_vert)
  • Sorting breaks the selection

@Innders Innders marked this pull request as ready for review February 17, 2025 08:13
@Innders Innders requested review from martastain and Innders and removed request for Innders February 17, 2025 08:15
@Innders Innders added the type: enhancement Improvement of existing functionality or minor addition label Feb 17, 2025
@Innders Innders changed the title feat(Settings): Installers management, UI/UX prepared, API calls & ca… Settings: Delete launcher and dependency files Feb 17, 2025
@martastain
Copy link
Member

Deleting works just fine, but:

  • it is super easy to accidentally delete a launcher / dp, that is a part of current production bundle, maybe the table could at least show a mark that the file is in use? (prod / staging / dev?)

  • shouldn't the buttons be labeled "manage launchers" / "manage dependency packages" when the dialog is not just about uploading anymore?

@Innders
Copy link
Member

Innders commented Feb 17, 2025

Added bundle statuses.

Eventually this whole thing could be moved to a dedicated page #1018

@Innders Innders assigned Innders and unassigned flynput Feb 17, 2025
@Innders Innders removed their request for review February 17, 2025 10:04
@Innders Innders merged commit e3d1c55 into develop Feb 17, 2025
@Innders Innders deleted the 734-bundles-unable-to-delete-launcher-and-dependency-packages branch February 17, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundles: Unable to delete launcher and dependency packages
3 participants